Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the MahApps Styles to match MahApps v2.x #249

Open
timunie opened this issue Jan 20, 2021 · 1 comment
Open

Update the MahApps Styles to match MahApps v2.x #249

timunie opened this issue Jan 20, 2021 · 1 comment

Comments

@timunie
Copy link

timunie commented Jan 20, 2021

Hi @ButchersBoy

I really love your library and MahApps.Metro together. MahApps.Metro got many breaking changes with version 2.x. Almost every ResourceKey got a new name, for example:

  • BlackBrush is now MahApps.Brushes.ThemeForeground
  • AccentBrush is now MahApps.Brushes.Accent

more Info: https://mahapps.com/docs/guides/migration-to-v2.0

This makes now much more sense to the users, but makes the provided MahApps-Styles unusable if one updates MahApps.

How should we proceed here?

  • Should I update the Style and make a PR here?
  • Would you like to introduce a new ResourceDictionary called MahApps_v2.xaml to avoid breaking changes (I can also make a PR)
  • Would you like to leave it as it is now? Then just close this issue

Thank you and happy coding
Tim

@josdemmers
Copy link

josdemmers commented May 17, 2021

@timunie Thanks for posting this here, had the same issue.
Was able to create a new local MahApps.xaml resource using your link:
https://mahapps.com/docs/guides/migration-to-v2.0

Not everything is working but at least I don't see any noticeable differences.
https://pastebin.com/D7XuiP4h

Note:
If anyone is planning to use this. I fixed it for the Dark.Green.xaml theme I was using.
So it could be you need to make some small modifications to make it match your theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants