From d8e7a3e3ef4c9862a227356fa2ef563dc8542b3c Mon Sep 17 00:00:00 2001
From: Shlomi Fish <shlomif@shlomifish.org>
Date: Tue, 4 Jun 2019 15:12:39 +0300
Subject: [PATCH] Extract a function or class to step away from God Object.

See:

* https://en.wikipedia.org/wiki/God_object

* https://www.c-sharpcorner.com/article/god-object-a-code-smell/ .

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
---
 pysollib/game.py | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/pysollib/game.py b/pysollib/game.py
index a7a26616fd..b7fefd6b5d 100644
--- a/pysollib/game.py
+++ b/pysollib/game.py
@@ -167,6 +167,16 @@ def _updateStatus_process_key_val(tb, sb, k, v):
     raise AttributeError(k)
 
 
+def _stats__is_perfect(stats):
+    """docstring for _stats__is_perfect"""
+    return (stats.undo_moves == 0 and
+            stats.goto_bookmark_moves == 0 and
+            # stats.quickplay_moves == 0 and
+            stats.highlight_piles == 0 and
+            stats.highlight_cards == 0 and
+            stats.shuffle_moves == 0)
+
+
 class Game(object):
     # for self.gstats.updated
     U_PLAY = 0
@@ -1813,7 +1823,7 @@ def canShuffle(self):
     #
 
     # game changed - i.e. should we ask the player to discard the game
-    def changed(self, restart=0):
+    def changed(self, restart=False):
         if self.gstats.updated < 0:
             return 0                    # already won or lost
         if self.gstats.loaded > 0:
@@ -1832,13 +1842,7 @@ def getWinStatus(self):
         if not won or self.stats.hints > 0 or self.stats.demo_moves > 0:
             # sorry, you lose
             return won, 0, self.U_LOST
-        if (self.stats.undo_moves == 0 and
-            self.stats.goto_bookmark_moves == 0 and
-            # self.stats.quickplay_moves == 0 and
-            self.stats.highlight_piles == 0 and
-            self.stats.highlight_cards == 0 and
-                self.stats.shuffle_moves == 0):
-            # perfect !
+        if _stats__is_perfect(self.stats):
             return won, 2, self.U_PERFECT
         return won, 1, self.U_WON