Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmo org #4

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Cosmo org #4

wants to merge 10 commits into from

Conversation

lxavier
Copy link

@lxavier lxavier commented Feb 21, 2020

changes for cosmo-org benchmark

@lxavier
Copy link
Author

lxavier commented Mar 24, 2020

@BenWeber42 do you see any reason why we should not merge this in master ?
@cosunae who should review this ?

@BenWeber42
Copy link

I don't see a problem merging this into master. But I don't know if this repository is used anywhere else where it could cause issues if we change the master?
I just didn't know the status of this repository. It looked somewhat abandoned when I introduced those changes.

But from my side, there's no problem merging the changes.

There may also be uncommitted changes to the font size. And it might be too big in the current jenkins plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants