Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go through all exercises before merging revision into main #105

Open
AnnikaLau opened this issue Apr 4, 2024 · 4 comments
Open

Go through all exercises before merging revision into main #105

AnnikaLau opened this issue Apr 4, 2024 · 4 comments
Labels
beginner Relevant for Beginner's course final check To be checked before next course for next year this issues don't make sense to resolve now, do it next year ahead of the next git-course

Comments

@AnnikaLau
Copy link
Contributor

As a final check, all exercise have to be done one more time to ensure no new bugs were introduced with all the changes.
@AnnikaLau AnnikaLau added final check To be checked before next course beginner Relevant for Beginner's course labels Apr 4, 2024
@AnnikaLau
Copy link
Contributor Author

AnnikaLau commented Apr 4, 2024 •
edited
Loading

We can distribute this task among us (the ones who are currently here, so @mjaehn, @leclairm and @AnnikaLau).

  • Matthieu checks exercise 1+4+7
  • Michael checks exercise 2+5
  • Annika checks exercise 3+6

Just follow the instructions in the exercises while being on branch revision and see if everything works as expected.
Next step would be to #101.
As soon as this is done, we can merge revision into main. Could you all still do this today?

@mjaehn
Copy link
Contributor

mjaehn commented Apr 4, 2024

I will do my part this evening.

@mjaehn
Copy link
Contributor

mjaehn commented Apr 4, 2024

@AnnikaLau Review done here #107

@AnnikaLau
Copy link
Contributor Author

Done by everybody. Let's keep this issue for next year.

@AnnikaLau AnnikaLau added the for next year this issues don't make sense to resolve now, do it next year ahead of the next git-course label Apr 5, 2024
@mjaehn mjaehn mentioned this issue Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner Relevant for Beginner's course final check To be checked before next course for next year this issues don't make sense to resolve now, do it next year ahead of the next git-course
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AnnikaLau @mjaehn