Add vertical advection granule with PPM #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI won't pass for now as this requires new data for the advection datatests. |
nfarabullini
requested changes
Nov 25, 2024
model/atmosphere/advection/src/icon4py/model/atmosphere/advection/advection_vertical.py
Show resolved
Hide resolved
model/atmosphere/advection/src/icon4py/model/atmosphere/advection/advection_vertical.py
Show resolved
Hide resolved
model/atmosphere/advection/src/icon4py/model/atmosphere/advection/advection_vertical.py
Outdated
Show resolved
Hide resolved
...re/advection/src/icon4py/model/atmosphere/advection/stencils/compute_ppm4gpu_integer_flux.py
Show resolved
Hide resolved
...ction/src/icon4py/model/atmosphere/advection/stencils/compute_vertical_tracer_flux_upwind.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run default |
|
launch jenkins spack |
|
Data for the advection datatests has been updated |
...re/advection/src/icon4py/model/atmosphere/advection/stencils/compute_ppm4gpu_integer_flux.py
Show resolved
Hide resolved
Comment on lines
+15
to
+16
| # TODO (dastrm): move this highly generic stencil to common | ||
| # TODO (dastrm): this stencil has no test |
There was a problem hiding this comment.
what about these TODOs?
There was a problem hiding this comment.
This will be moved to common later where there is already a test for this stencil
...n/src/icon4py/model/atmosphere/advection/stencils/limit_vertical_slope_semi_monotonically.py
Show resolved
Hide resolved
...here/advection/tests/advection_stencil_tests/test_limit_vertical_slope_semi_monotonically.py
Outdated
Show resolved
Hide resolved
...ction/src/icon4py/model/atmosphere/advection/stencils/compute_vertical_tracer_flux_upwind.py
Show resolved
Hide resolved
...re/advection/src/icon4py/model/atmosphere/advection/stencils/compute_ppm4gpu_integer_flux.py
Show resolved
Hide resolved
...advection/src/icon4py/model/atmosphere/advection/stencils/compute_ppm4gpu_fractional_flux.py
Show resolved
Hide resolved
...advection/src/icon4py/model/atmosphere/advection/stencils/compute_ppm4gpu_fractional_flux.py
Show resolved
Hide resolved
.../advection/src/icon4py/model/atmosphere/advection/stencils/compute_ppm4gpu_courant_number.py
Show resolved
Hide resolved
nfarabullini
approved these changes
Nov 29, 2024
|
cscs-ci run default |
|
launch jenkins spack |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
egparedes
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Add vertical advection granule with PPM --------- Co-authored-by: Nicoletta Farabullini <[email protected]>
jcanton
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Add vertical advection granule with PPM --------- Co-authored-by: Nicoletta Farabullini <[email protected]>
OngChia
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Add vertical advection granule with PPM --------- Co-authored-by: Nicoletta Farabullini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the horizontal tracer transport, this adds a non-abstract class
PiecewiseParabolicMethod, which implements vertical tracer transport for a single tracer. This class is meant to be initialized once, can be run successively in a time loop and can be tested in isolation. Currently, it is verified with serialized data from a single time step. Additionally, this adds a couple of new stencils that are currently missing in the blueline for various reasons.