-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ICON interpolator (to point locations) #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@efmkoene Thanks for this PR! I will review this one and already set the base branch to v3.1-rc. Since here, just one file is added, there is no conflict. |
mjaehn
reviewed
Feb 5, 2024
mjaehn
reviewed
Feb 5, 2024
mjaehn
reviewed
Feb 5, 2024
mjaehn
reviewed
Feb 5, 2024
mjaehn
reviewed
Feb 5, 2024
mjaehn
reviewed
Feb 5, 2024
mjaehn
requested changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
mjaehn
reviewed
Feb 5, 2024
Hopefully it's up to scratch now! |
launch jenkins |
mjaehn
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a tool to the
tools
folder, which can interpolate ICON output to point locations, using inverse distance weighted interpolation horizontally, and linear interpolation vertically. [*]It can also be called from the command line (but with reduced performance, as only one lon/lat point can be interpolated at a time).
It relies on a relatively modern
xarray
version (I have2023.7.0
), but that is automatically the case with the way the current conda environment is set up anyhow.From the review, I would mainly ask for a good descriptive word that makes the difference between
station_ground_elevation
andstation_altitude_over_ground
as clear as possible -- it probably isn't a 100% clear right now. This is what it should correspond to:station_ground_elevation=0
(as that is the local topography) whilestation_altitude_over_ground=27
(as that is the inlet height over the ground)station_ground_elevation=3580
(as that is the local topography) whilestation_altitude_over_ground=5
(as that is the inlet height over the ground)[*] (As a curious sidenote, inverse distance weighted interpolation == linear interpolation when only 2 points are considered. So, really, it is using inverse distance weighing both horizontally and vertically).