From fd1e60b20e444132d25fa02733d36fdc3908a3f7 Mon Sep 17 00:00:00 2001 From: Gerard Soldevila Date: Wed, 8 Jan 2025 22:20:14 +0100 Subject: [PATCH] SKA: Categorise remaining packages (#205875) ## Summary * Delete unused package `@kbn/formatters` * Delete unused package `@kbn/response-ops-feature-flag-service` * Flag `@kbn/generate-console-definitions` as `devOnly: true` * Flag `@kbn/plugin-check` as `devOnly: true` * Flag `@kbn/set-map` as `devOnly: true` * Flag `@kbn/synthetics-private-location` as `devOnly: true` * Categorise `@kbn/calculate-auto` as `platform/shared` * Categorise `@kbn/charts-theme` as `platform/shared` * Categorise `@kbn/saved-search-component` as `platform/shared` * Categorise `@kbn/use-tracked-promise` as `platform/shared` * Categorise `@kbn/charts-theme` as `platform/shared` * Categorise `@kbn/response-ops-rule-form` as `platform/shared` --- .github/CODEOWNERS | 2 - examples/grid_example/kibana.jsonc | 2 + package.json | 10 ++--- packages/kbn-calculate-auto/kibana.jsonc | 4 +- packages/kbn-charts-theme/kibana.jsonc | 4 +- packages/kbn-formatters/REASDME.md | 3 -- packages/kbn-formatters/index.ts | 10 ----- packages/kbn-formatters/jest.config.js | 14 ------- packages/kbn-formatters/kibana.jsonc | 5 --- packages/kbn-formatters/package.json | 6 --- .../src/bytes_formatter/index.test.ts | 37 ------------------- .../src/bytes_formatter/index.ts | 20 ---------- packages/kbn-formatters/tsconfig.json | 17 --------- .../kibana.jsonc | 3 +- packages/kbn-grid-layout/kibana.jsonc | 4 +- packages/kbn-palettes/kibana.jsonc | 4 +- packages/kbn-plugin-check/kibana.jsonc | 3 +- .../kbn-saved-search-component/kibana.jsonc | 4 +- packages/kbn-set-map/kibana.jsonc | 3 +- packages/kbn-use-tracked-promise/kibana.jsonc | 4 +- .../feature_flag_service/README.md | 27 -------------- .../feature_flag_service.test.ts | 30 --------------- .../feature_flag_service.ts | 26 ------------- .../feature_flag_service/index.ts | 11 ------ .../feature_flag_service/jest.config.js | 14 ------- .../feature_flag_service/kibana.jsonc | 5 --- .../feature_flag_service/package.json | 6 --- .../feature_flag_service/tsconfig.json | 17 --------- packages/response-ops/rule_form/kibana.jsonc | 4 +- tsconfig.base.json | 4 -- .../kibana.jsonc | 3 +- yarn.lock | 8 ---- 32 files changed, 35 insertions(+), 279 deletions(-) delete mode 100644 packages/kbn-formatters/REASDME.md delete mode 100644 packages/kbn-formatters/index.ts delete mode 100644 packages/kbn-formatters/jest.config.js delete mode 100644 packages/kbn-formatters/kibana.jsonc delete mode 100644 packages/kbn-formatters/package.json delete mode 100644 packages/kbn-formatters/src/bytes_formatter/index.test.ts delete mode 100644 packages/kbn-formatters/src/bytes_formatter/index.ts delete mode 100644 packages/kbn-formatters/tsconfig.json delete mode 100644 packages/response-ops/feature_flag_service/README.md delete mode 100644 packages/response-ops/feature_flag_service/feature_flag_service.test.ts delete mode 100644 packages/response-ops/feature_flag_service/feature_flag_service.ts delete mode 100644 packages/response-ops/feature_flag_service/index.ts delete mode 100644 packages/response-ops/feature_flag_service/jest.config.js delete mode 100644 packages/response-ops/feature_flag_service/kibana.jsonc delete mode 100644 packages/response-ops/feature_flag_service/package.json delete mode 100644 packages/response-ops/feature_flag_service/tsconfig.json diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 9fac39dc30a39..3ab540b271518 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -146,7 +146,6 @@ packages/kbn-eslint-plugin-telemetry @elastic/obs-knowledge-team packages/kbn-expect @elastic/kibana-operations @elastic/appex-qa packages/kbn-failed-test-reporter-cli @elastic/kibana-operations @elastic/appex-qa packages/kbn-find-used-node-modules @elastic/kibana-operations -packages/kbn-formatters @elastic/obs-ux-logs-team packages/kbn-ftr-common-functional-services @elastic/kibana-operations @elastic/appex-qa packages/kbn-ftr-common-functional-ui-services @elastic/appex-qa packages/kbn-ftr-screenshot-filename @elastic/kibana-operations @elastic/appex-qa @@ -222,7 +221,6 @@ packages/react/kibana_context/root @elastic/appex-sharedux packages/react/kibana_context/styled @elastic/appex-sharedux packages/react/kibana_context/theme @elastic/appex-sharedux packages/react/kibana_mount @elastic/appex-sharedux -packages/response-ops/feature_flag_service @elastic/response-ops packages/response-ops/rule_form @elastic/response-ops packages/serverless/project_switcher @elastic/appex-sharedux packages/serverless/settings/common @elastic/appex-sharedux @elastic/kibana-management diff --git a/examples/grid_example/kibana.jsonc b/examples/grid_example/kibana.jsonc index 046838a4393ca..5f4755f20d753 100644 --- a/examples/grid_example/kibana.jsonc +++ b/examples/grid_example/kibana.jsonc @@ -2,6 +2,8 @@ "type": "plugin", "id": "@kbn/grid-example-plugin", "owner": "@elastic/kibana-presentation", + "group": "platform", + "visibility": "private", "description": "Temporary example app used to build out the new Dashboard layout system", "plugin": { "id": "gridExample", diff --git a/package.json b/package.json index 74512a25e6b55..5b3ecadb48dfa 100644 --- a/package.json +++ b/package.json @@ -539,11 +539,9 @@ "@kbn/fleet-plugin": "link:x-pack/platform/plugins/shared/fleet", "@kbn/flot-charts": "link:src/platform/packages/shared/kbn-flot-charts", "@kbn/foo-plugin": "link:x-pack/test/ui_capabilities/common/plugins/foo_plugin", - "@kbn/formatters": "link:packages/kbn-formatters", "@kbn/ftr-apis-plugin": "link:src/platform/plugins/private/ftr_apis", "@kbn/functional-with-es-ssl-cases-test-plugin": "link:x-pack/test/functional_with_es_ssl/plugins/cases", "@kbn/gen-ai-streaming-response-example-plugin": "link:x-pack/examples/gen_ai_streaming_response_example", - "@kbn/generate-console-definitions": "link:packages/kbn-generate-console-definitions", "@kbn/generate-csv": "link:src/platform/packages/private/kbn-generate-csv", "@kbn/global-search-bar-plugin": "link:x-pack/platform/plugins/private/global_search_bar", "@kbn/global-search-plugin": "link:x-pack/platform/plugins/shared/global_search", @@ -719,7 +717,6 @@ "@kbn/painless-lab-plugin": "link:x-pack/platform/plugins/private/painless_lab", "@kbn/palettes": "link:packages/kbn-palettes", "@kbn/panel-loader": "link:src/platform/packages/private/kbn-panel-loader", - "@kbn/plugin-check": "link:packages/kbn-plugin-check", "@kbn/portable-dashboards-example": "link:examples/portable_dashboards_example", "@kbn/preboot-example-plugin": "link:examples/preboot_example", "@kbn/presentation-containers": "link:src/platform/packages/shared/presentation/presentation_containers", @@ -761,7 +758,6 @@ "@kbn/resizable-layout": "link:src/platform/packages/shared/kbn-resizable-layout", "@kbn/resizable-layout-examples-plugin": "link:examples/resizable_layout_examples", "@kbn/resolver-test-plugin": "link:x-pack/test/plugin_functional/plugins/resolver_test", - "@kbn/response-ops-feature-flag-service": "link:packages/response-ops/feature_flag_service", "@kbn/response-ops-rule-form": "link:packages/response-ops/rule_form", "@kbn/response-ops-rule-params": "link:src/platform/packages/shared/response-ops/rule_params", "@kbn/response-stream-plugin": "link:examples/response_stream", @@ -874,7 +870,6 @@ "@kbn/serverless-types": "link:packages/serverless/types", "@kbn/session-notifications-plugin": "link:test/plugin_functional/plugins/session_notifications", "@kbn/session-view-plugin": "link:x-pack/solutions/security/plugins/session_view", - "@kbn/set-map": "link:packages/kbn-set-map", "@kbn/share-examples-plugin": "link:examples/share_examples", "@kbn/share-plugin": "link:src/platform/plugins/shared/share", "@kbn/shared-svg": "link:src/platform/packages/shared/kbn-shared-svg", @@ -948,7 +943,6 @@ "@kbn/streams-plugin": "link:x-pack/solutions/observability/plugins/streams", "@kbn/streams-schema": "link:x-pack/packages/kbn-streams-schema", "@kbn/synthetics-plugin": "link:x-pack/solutions/observability/plugins/synthetics", - "@kbn/synthetics-private-location": "link:x-pack/packages/kbn-synthetics-private-location", "@kbn/task-manager-fixture-plugin": "link:x-pack/test/alerting_api_integration/common/plugins/task_manager_fixture", "@kbn/task-manager-performance-plugin": "link:x-pack/test/plugin_api_perf/plugins/task_manager_performance", "@kbn/task-manager-plugin": "link:x-pack/platform/plugins/shared/task_manager", @@ -1464,6 +1458,7 @@ "@kbn/ftr-screenshot-filename": "link:packages/kbn-ftr-screenshot-filename", "@kbn/gen-ai-functional-testing": "link:packages/kbn-gen-ai-functional-testing", "@kbn/generate": "link:packages/kbn-generate", + "@kbn/generate-console-definitions": "link:packages/kbn-generate-console-definitions", "@kbn/get-repo-files": "link:packages/kbn-get-repo-files", "@kbn/import-locator": "link:packages/kbn-import-locator", "@kbn/import-resolver": "link:packages/kbn-import-resolver", @@ -1489,6 +1484,7 @@ "@kbn/peggy-loader": "link:packages/kbn-peggy-loader", "@kbn/performance-testing-dataset-extractor": "link:packages/kbn-performance-testing-dataset-extractor", "@kbn/picomatcher": "link:packages/kbn-picomatcher", + "@kbn/plugin-check": "link:packages/kbn-plugin-check", "@kbn/plugin-generator": "link:packages/kbn-plugin-generator", "@kbn/plugin-helpers": "link:packages/kbn-plugin-helpers", "@kbn/product-doc-artifact-builder": "link:x-pack/packages/ai-infra/product-doc-artifact-builder", @@ -1503,12 +1499,14 @@ "@kbn/scout-reporting": "link:packages/kbn-scout-reporting", "@kbn/security-api-integration-helpers": "link:x-pack/test/security_api_integration/packages/helpers", "@kbn/serverless-storybook-config": "link:packages/serverless/storybook/config", + "@kbn/set-map": "link:packages/kbn-set-map", "@kbn/some-dev-log": "link:packages/kbn-some-dev-log", "@kbn/sort-package-json": "link:packages/kbn-sort-package-json", "@kbn/stdio-dev-helpers": "link:packages/kbn-stdio-dev-helpers", "@kbn/storybook": "link:packages/kbn-storybook", "@kbn/styled-components-mapping-cli": "link:packages/kbn-styled-components-mapping-cli", "@kbn/synthetics-e2e": "link:x-pack/solutions/observability/plugins/synthetics/e2e", + "@kbn/synthetics-private-location": "link:x-pack/packages/kbn-synthetics-private-location", "@kbn/telemetry-tools": "link:packages/kbn-telemetry-tools", "@kbn/test": "link:packages/kbn-test", "@kbn/test-eui-helpers": "link:packages/kbn-test-eui-helpers", diff --git a/packages/kbn-calculate-auto/kibana.jsonc b/packages/kbn-calculate-auto/kibana.jsonc index 2ce6c776f1a69..846b30744f39f 100644 --- a/packages/kbn-calculate-auto/kibana.jsonc +++ b/packages/kbn-calculate-auto/kibana.jsonc @@ -1,5 +1,7 @@ { "type": "shared-common", "id": "@kbn/calculate-auto", - "owner": "@elastic/obs-ux-management-team" + "owner": "@elastic/obs-ux-management-team", + "group": "platform", + "visibility": "shared" } diff --git a/packages/kbn-charts-theme/kibana.jsonc b/packages/kbn-charts-theme/kibana.jsonc index b43497bc92ba9..2d3aa1dcc782f 100644 --- a/packages/kbn-charts-theme/kibana.jsonc +++ b/packages/kbn-charts-theme/kibana.jsonc @@ -1,5 +1,7 @@ { "type": "shared-common", "id": "@kbn/charts-theme", - "owner": "@elastic/kibana-visualizations" + "owner": "@elastic/kibana-visualizations", + "group": "platform", + "visibility": "shared" } diff --git a/packages/kbn-formatters/REASDME.md b/packages/kbn-formatters/REASDME.md deleted file mode 100644 index dba100fa2e3a8..0000000000000 --- a/packages/kbn-formatters/REASDME.md +++ /dev/null @@ -1,3 +0,0 @@ -# @kbn/formatters - -Utilities for formatting common fields and values. diff --git a/packages/kbn-formatters/index.ts b/packages/kbn-formatters/index.ts deleted file mode 100644 index c3eb4513f54d9..0000000000000 --- a/packages/kbn-formatters/index.ts +++ /dev/null @@ -1,10 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the "Elastic License - * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side - * Public License v 1"; you may not use this file except in compliance with, at - * your election, the "Elastic License 2.0", the "GNU Affero General Public - * License v3.0 only", or the "Server Side Public License, v 1". - */ - -export { formatBytes } from './src/bytes_formatter'; diff --git a/packages/kbn-formatters/jest.config.js b/packages/kbn-formatters/jest.config.js deleted file mode 100644 index f42dcadaf8814..0000000000000 --- a/packages/kbn-formatters/jest.config.js +++ /dev/null @@ -1,14 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the "Elastic License - * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side - * Public License v 1"; you may not use this file except in compliance with, at - * your election, the "Elastic License 2.0", the "GNU Affero General Public - * License v3.0 only", or the "Server Side Public License, v 1". - */ - -module.exports = { - preset: '@kbn/test', - rootDir: '../..', - roots: ['/packages/kbn-formatters'], -}; diff --git a/packages/kbn-formatters/kibana.jsonc b/packages/kbn-formatters/kibana.jsonc deleted file mode 100644 index 67f2247125ee3..0000000000000 --- a/packages/kbn-formatters/kibana.jsonc +++ /dev/null @@ -1,5 +0,0 @@ -{ - "type": "shared-common", - "id": "@kbn/formatters", - "owner": "@elastic/obs-ux-logs-team" -} diff --git a/packages/kbn-formatters/package.json b/packages/kbn-formatters/package.json deleted file mode 100644 index b45b7304385b5..0000000000000 --- a/packages/kbn-formatters/package.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "name": "@kbn/formatters", - "private": true, - "version": "1.0.0", - "license": "Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0" -} \ No newline at end of file diff --git a/packages/kbn-formatters/src/bytes_formatter/index.test.ts b/packages/kbn-formatters/src/bytes_formatter/index.test.ts deleted file mode 100644 index 011cc9849e3ad..0000000000000 --- a/packages/kbn-formatters/src/bytes_formatter/index.test.ts +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the "Elastic License - * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side - * Public License v 1"; you may not use this file except in compliance with, at - * your election, the "Elastic License 2.0", the "GNU Affero General Public - * License v3.0 only", or the "Server Side Public License, v 1". - */ - -import { formatBytes } from '.'; - -describe('BytesFormatter', () => { - it('should format bytes correctly', () => { - const result = formatBytes(1000); - expect(result).toBe('1000 Bytes'); - }); - - it('should format bytes correctly if 0 is sent', () => { - const result = formatBytes(0); - expect(result).toBe('0 Bytes'); - }); - - it('should format bytes correctly into KB', () => { - const result = formatBytes(10000); - expect(result).toBe('10 KB'); - }); - - it('should format bytes correctly into MB', () => { - const result = formatBytes(1048576); - expect(result).toBe('1 MB'); - }); - - it('should format bytes correctly with decimals', () => { - const result = formatBytes(10000, 3); - expect(result).toBe('9.766 KB'); - }); -}); diff --git a/packages/kbn-formatters/src/bytes_formatter/index.ts b/packages/kbn-formatters/src/bytes_formatter/index.ts deleted file mode 100644 index 035b858abf440..0000000000000 --- a/packages/kbn-formatters/src/bytes_formatter/index.ts +++ /dev/null @@ -1,20 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the "Elastic License - * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side - * Public License v 1"; you may not use this file except in compliance with, at - * your election, the "Elastic License 2.0", the "GNU Affero General Public - * License v3.0 only", or the "Server Side Public License, v 1". - */ - -export const formatBytes = (bytes: number, decimals = 0) => { - if (bytes === 0) return '0 Bytes'; - - const k = 1024; - const dm = decimals < 0 ? 0 : decimals; - const sizes = ['Bytes', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']; - - const i = Math.floor(Math.log(bytes) / Math.log(k)); - - return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i]; -}; diff --git a/packages/kbn-formatters/tsconfig.json b/packages/kbn-formatters/tsconfig.json deleted file mode 100644 index 21fe7cbde89a0..0000000000000 --- a/packages/kbn-formatters/tsconfig.json +++ /dev/null @@ -1,17 +0,0 @@ -{ - "extends": "../../tsconfig.base.json", - "compilerOptions": { - "outDir": "target/types", - "types": [ - "jest", - "node", - ] - }, - "include": [ - "**/*.ts", - ], - "exclude": [ - "target/**/*" - ], - "kbn_references": [] -} diff --git a/packages/kbn-generate-console-definitions/kibana.jsonc b/packages/kbn-generate-console-definitions/kibana.jsonc index 1ec3c82923f33..ef87a5267e042 100644 --- a/packages/kbn-generate-console-definitions/kibana.jsonc +++ b/packages/kbn-generate-console-definitions/kibana.jsonc @@ -1,5 +1,6 @@ { "type": "shared-common", "id": "@kbn/generate-console-definitions", - "owner": "@elastic/kibana-management" + "owner": "@elastic/kibana-management", + "devOnly": true } diff --git a/packages/kbn-grid-layout/kibana.jsonc b/packages/kbn-grid-layout/kibana.jsonc index 8063456ea0b5f..cc0e1a4a204d0 100644 --- a/packages/kbn-grid-layout/kibana.jsonc +++ b/packages/kbn-grid-layout/kibana.jsonc @@ -1,5 +1,7 @@ { "type": "shared-browser", "id": "@kbn/grid-layout", - "owner": "@elastic/kibana-presentation" + "owner": "@elastic/kibana-presentation", + "group": "platform", + "visibility": "private" } diff --git a/packages/kbn-palettes/kibana.jsonc b/packages/kbn-palettes/kibana.jsonc index 940c34426c2bc..3f33459254c93 100644 --- a/packages/kbn-palettes/kibana.jsonc +++ b/packages/kbn-palettes/kibana.jsonc @@ -1,5 +1,7 @@ { "type": "shared-common", "id": "@kbn/palettes", - "owner": "@elastic/kibana-visualizations" + "owner": "@elastic/kibana-visualizations", + "group": "platform", + "visibility": "shared" } diff --git a/packages/kbn-plugin-check/kibana.jsonc b/packages/kbn-plugin-check/kibana.jsonc index 1f14120b75ba9..d9fe4720d7ce9 100644 --- a/packages/kbn-plugin-check/kibana.jsonc +++ b/packages/kbn-plugin-check/kibana.jsonc @@ -1,5 +1,6 @@ { "type": "shared-server", "id": "@kbn/plugin-check", - "owner": "@elastic/appex-sharedux" + "owner": "@elastic/appex-sharedux", + "devOnly": true } diff --git a/packages/kbn-saved-search-component/kibana.jsonc b/packages/kbn-saved-search-component/kibana.jsonc index d0de843443d12..07803aad83dde 100644 --- a/packages/kbn-saved-search-component/kibana.jsonc +++ b/packages/kbn-saved-search-component/kibana.jsonc @@ -1,5 +1,7 @@ { "type": "shared-browser", "id": "@kbn/saved-search-component", - "owner": "@elastic/obs-ux-logs-team" + "owner": "@elastic/obs-ux-logs-team", + "group": "platform", + "visibility": "shared" } diff --git a/packages/kbn-set-map/kibana.jsonc b/packages/kbn-set-map/kibana.jsonc index 609e6e8a0c8a8..d5fc6fe96097b 100644 --- a/packages/kbn-set-map/kibana.jsonc +++ b/packages/kbn-set-map/kibana.jsonc @@ -1,5 +1,6 @@ { "type": "shared-common", "id": "@kbn/set-map", - "owner": "@elastic/kibana-operations" + "owner": "@elastic/kibana-operations", + "devOnly": true } diff --git a/packages/kbn-use-tracked-promise/kibana.jsonc b/packages/kbn-use-tracked-promise/kibana.jsonc index 959dda0d05a66..5d620f3c43302 100644 --- a/packages/kbn-use-tracked-promise/kibana.jsonc +++ b/packages/kbn-use-tracked-promise/kibana.jsonc @@ -1,5 +1,7 @@ { "type": "shared-common", "id": "@kbn/use-tracked-promise", - "owner": "@elastic/obs-ux-logs-team" + "owner": "@elastic/obs-ux-logs-team", + "group": "platform", + "visibility": "shared" } diff --git a/packages/response-ops/feature_flag_service/README.md b/packages/response-ops/feature_flag_service/README.md deleted file mode 100644 index e1f2cc2d9e387..0000000000000 --- a/packages/response-ops/feature_flag_service/README.md +++ /dev/null @@ -1,27 +0,0 @@ -# @kbn/response-ops-feature-flags - -This packages exposes a feature flag service that is used in the ResponseOps plugins and packages to handle feature flags. - -## Usage - -### Create feature flag service - -``` -const featureFlagService = createFeatureFlagService(['test.myFeature', 'test.myFeature.subFeature']); // TS will infer the types automatically -``` - -or - -``` -type FeatureFlagValues = 'test.myFeature' | 'test.myOtherFeature' -const featureFlagService = createFeatureFlagService(['test.myFeature']); -``` - -### Checking the existence of a feature flag -``` -const featureFlagService = createFeatureFlagService(['test.myFeature', 'test.myFeature.subFeature']); - -if (featureFlagService.isFeatureFlagSet('test.myFeature')) { - // my feature code -} -``` \ No newline at end of file diff --git a/packages/response-ops/feature_flag_service/feature_flag_service.test.ts b/packages/response-ops/feature_flag_service/feature_flag_service.test.ts deleted file mode 100644 index 33363ebf31084..0000000000000 --- a/packages/response-ops/feature_flag_service/feature_flag_service.test.ts +++ /dev/null @@ -1,30 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the "Elastic License - * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side - * Public License v 1"; you may not use this file except in compliance with, at - * your election, the "Elastic License 2.0", the "GNU Affero General Public - * License v3.0 only", or the "Server Side Public License, v 1". - */ - -import { createFeatureFlagService } from './feature_flag_service'; - -type FeatureFlagValues = 'test.myFeature' | 'test.myOtherFeature'; - -describe('FeatureFlagService', () => { - it('returns true if the feature exists', () => { - const featureFlagService = createFeatureFlagService(['test.myFeature']); - expect(featureFlagService.isFeatureFlagSet('test.myFeature')).toBe(true); - }); - - it('returns false if the feature does not exist', () => { - const featureFlagService = createFeatureFlagService(['test.myFeature']); - // @ts-expect-error: foo is not part of the valid feature flags - expect(featureFlagService.isFeatureFlagSet('foo')).toBe(false); - }); - - it('returns true if the feature exists (as typed)', () => { - const featureFlagService = createFeatureFlagService(['test.myFeature']); - expect(featureFlagService.isFeatureFlagSet('test.myFeature')).toBe(true); - }); -}); diff --git a/packages/response-ops/feature_flag_service/feature_flag_service.ts b/packages/response-ops/feature_flag_service/feature_flag_service.ts deleted file mode 100644 index 4f6f2f2f5acff..0000000000000 --- a/packages/response-ops/feature_flag_service/feature_flag_service.ts +++ /dev/null @@ -1,26 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the "Elastic License - * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side - * Public License v 1"; you may not use this file except in compliance with, at - * your election, the "Elastic License 2.0", the "GNU Affero General Public - * License v3.0 only", or the "Server Side Public License, v 1". - */ - -class FeatureFlag { - private readonly featureFlags = new Set(); - - constructor(featureFlags: T[]) { - featureFlags.forEach((featureFlag) => this.featureFlags.add(featureFlag)); - } - - public isFeatureFlagSet(featureFlag: T): boolean { - return this.featureFlags.has(featureFlag); - } -} - -export const createFeatureFlagService = (featureFlags: T[]) => { - return new FeatureFlag<(typeof featureFlags)[number]>(featureFlags); -}; - -export type FeatureFlagService = InstanceType>; diff --git a/packages/response-ops/feature_flag_service/index.ts b/packages/response-ops/feature_flag_service/index.ts deleted file mode 100644 index 0a2954e7ff49c..0000000000000 --- a/packages/response-ops/feature_flag_service/index.ts +++ /dev/null @@ -1,11 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the "Elastic License - * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side - * Public License v 1"; you may not use this file except in compliance with, at - * your election, the "Elastic License 2.0", the "GNU Affero General Public - * License v3.0 only", or the "Server Side Public License, v 1". - */ - -export { createFeatureFlagService } from './feature_flag_service'; -export type { FeatureFlagService } from './feature_flag_service'; diff --git a/packages/response-ops/feature_flag_service/jest.config.js b/packages/response-ops/feature_flag_service/jest.config.js deleted file mode 100644 index fd89c66ac9df0..0000000000000 --- a/packages/response-ops/feature_flag_service/jest.config.js +++ /dev/null @@ -1,14 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the "Elastic License - * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side - * Public License v 1"; you may not use this file except in compliance with, at - * your election, the "Elastic License 2.0", the "GNU Affero General Public - * License v3.0 only", or the "Server Side Public License, v 1". - */ - -module.exports = { - preset: '@kbn/test/jest_node', - rootDir: '../../..', - roots: ['/packages/response-ops/feature_flag_service'], -}; diff --git a/packages/response-ops/feature_flag_service/kibana.jsonc b/packages/response-ops/feature_flag_service/kibana.jsonc deleted file mode 100644 index 9d52b84f64ec2..0000000000000 --- a/packages/response-ops/feature_flag_service/kibana.jsonc +++ /dev/null @@ -1,5 +0,0 @@ -{ - "type": "shared-common", - "id": "@kbn/response-ops-feature-flag-service", - "owner": "@elastic/response-ops" -} diff --git a/packages/response-ops/feature_flag_service/package.json b/packages/response-ops/feature_flag_service/package.json deleted file mode 100644 index 543caecc2bf53..0000000000000 --- a/packages/response-ops/feature_flag_service/package.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "name": "@kbn/response-ops-feature-flag-service", - "private": true, - "version": "1.0.0", - "license": "Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0" -} diff --git a/packages/response-ops/feature_flag_service/tsconfig.json b/packages/response-ops/feature_flag_service/tsconfig.json deleted file mode 100644 index 6d27b06d5f8ba..0000000000000 --- a/packages/response-ops/feature_flag_service/tsconfig.json +++ /dev/null @@ -1,17 +0,0 @@ -{ - "extends": "../../../tsconfig.base.json", - "compilerOptions": { - "outDir": "target/types", - "types": [ - "jest", - "node" - ] - }, - "include": [ - "**/*.ts", - ], - "exclude": [ - "target/**/*" - ], - "kbn_references": [] -} diff --git a/packages/response-ops/rule_form/kibana.jsonc b/packages/response-ops/rule_form/kibana.jsonc index e8538a088a557..b90baba85ea3d 100644 --- a/packages/response-ops/rule_form/kibana.jsonc +++ b/packages/response-ops/rule_form/kibana.jsonc @@ -1,5 +1,7 @@ { "type": "shared-browser", "id": "@kbn/response-ops-rule-form", - "owner": "@elastic/response-ops" + "owner": "@elastic/response-ops", + "group": "platform", + "visibility": "shared" } diff --git a/tsconfig.base.json b/tsconfig.base.json index 66634bff0d028..bae795ba57553 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -970,8 +970,6 @@ "@kbn/flot-charts/*": ["src/platform/packages/shared/kbn-flot-charts/*"], "@kbn/foo-plugin": ["x-pack/test/ui_capabilities/common/plugins/foo_plugin"], "@kbn/foo-plugin/*": ["x-pack/test/ui_capabilities/common/plugins/foo_plugin/*"], - "@kbn/formatters": ["packages/kbn-formatters"], - "@kbn/formatters/*": ["packages/kbn-formatters/*"], "@kbn/ftr-apis-plugin": ["src/platform/plugins/private/ftr_apis"], "@kbn/ftr-apis-plugin/*": ["src/platform/plugins/private/ftr_apis/*"], "@kbn/ftr-common-functional-services": ["packages/kbn-ftr-common-functional-services"], @@ -1492,8 +1490,6 @@ "@kbn/resizable-layout-examples-plugin/*": ["examples/resizable_layout_examples/*"], "@kbn/resolver-test-plugin": ["x-pack/test/plugin_functional/plugins/resolver_test"], "@kbn/resolver-test-plugin/*": ["x-pack/test/plugin_functional/plugins/resolver_test/*"], - "@kbn/response-ops-feature-flag-service": ["packages/response-ops/feature_flag_service"], - "@kbn/response-ops-feature-flag-service/*": ["packages/response-ops/feature_flag_service/*"], "@kbn/response-ops-rule-form": ["packages/response-ops/rule_form"], "@kbn/response-ops-rule-form/*": ["packages/response-ops/rule_form/*"], "@kbn/response-ops-rule-params": ["src/platform/packages/shared/response-ops/rule_params"], diff --git a/x-pack/packages/kbn-synthetics-private-location/kibana.jsonc b/x-pack/packages/kbn-synthetics-private-location/kibana.jsonc index 6ff6d3f1645c2..c8e16ddfc2f8b 100644 --- a/x-pack/packages/kbn-synthetics-private-location/kibana.jsonc +++ b/x-pack/packages/kbn-synthetics-private-location/kibana.jsonc @@ -1,5 +1,6 @@ { "type": "shared-common", "id": "@kbn/synthetics-private-location", - "owner": "@elastic/obs-ux-management-team" + "owner": "@elastic/obs-ux-management-team", + "devOnly": true } diff --git a/yarn.lock b/yarn.lock index 953ed09385bdd..d85b709bfcee1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5793,10 +5793,6 @@ version "0.0.0" uid "" -"@kbn/formatters@link:packages/kbn-formatters": - version "0.0.0" - uid "" - "@kbn/ftr-apis-plugin@link:src/platform/plugins/private/ftr_apis": version "0.0.0" uid "" @@ -6837,10 +6833,6 @@ version "0.0.0" uid "" -"@kbn/response-ops-feature-flag-service@link:packages/response-ops/feature_flag_service": - version "0.0.0" - uid "" - "@kbn/response-ops-rule-form@link:packages/response-ops/rule_form": version "0.0.0" uid ""