Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load more - unresponsive af #9

Open
sparcut opened this issue Nov 18, 2017 · 2 comments
Open

load more - unresponsive af #9

sparcut opened this issue Nov 18, 2017 · 2 comments

Comments

@sparcut
Copy link

sparcut commented Nov 18, 2017

When you click load more on main page, site becomes unresponsive af, blocks input until loaded more.

@CBenni
Copy link
Owner

CBenni commented Nov 18, 2017

Hey, this is a known issue, with not a lot I can really do about it (I might replace it with some kind of infinite scroll) - it simply has to do with the fact that loading 4000 buttons is slow af in angular.
When this version of the logviewer was originally created, the list of channels was just 40, which worked totally fine, but nowadays that list is more than 100 times as large, so it no longer performs well; I am currently working on the logviewer v4 which will fix scaling issues like these.

For now, I suggest simply not clicking the button and searching for the channel you are looking for via the search box.

Hope that answers your question!

@sparcut
Copy link
Author

sparcut commented Dec 20, 2017

I haven't used Angular >2 and I only had a quick glance, but it looks like you have a channellimit which is used to render x amount of channels.

Instead of setting that to undefined, why not add 50 or something to that each time it's clicked. Could start to get complicated with in, lazy load the next 'page'. All channels are returned from api? (prob fine cause small though)

Anyway, you're rewriting. Will it be using Angular <2? (I don't see branch 🤔)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants