make qualtrics survey instance id nullable on result objects #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another short PR -- the survey extract was hard-crashing when invalid instance_ids were provided. This combined with a partner PR in platform should fix it. (no change to SQL should be needed. This field is nullable in the database.
I chose this approach over switching everything to a string (the raw data returned from the API) because we currently have a foreign key relationship. I think it's theoretically still possible for a third party to crash this process by inputting a random UUID through manual URL editing, but it's much less likely and would require a seperate fix.