-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genutil.area_weights doesn't work with non-cartesian grids (most CMIP5 ocean grids) #6
Comments
@chaosphere2112 @doutriaux1 same here |
@durack1 in the mean time you can try to use zonalmeans |
Marking issue as stale, since there has been no activity in 30 days. Unless the issue is updated or the 'stale' tag is removed, this issue will be closed in 7 days. |
@jasonb5 this is a pretty big standing issue, as many of the CMIP5 and now CMIP6 grids (both atmospheric and oceanic) are now non-cartesian, it would be great if these functions were updated to be grid aware and worked as you'd expect |
That would be nice. The least to do would be to print a warning telling the user to try to locate a CMIPn Some casual CMIPn data users don't know about areacella |
@jypeter not a bad suggestion, we might have to make this a little smarter, so only if a CMIPx file is being read, but I suppose a generic warning could also be useful |
For the current version of CDMS we can add an improved generialized error and update the averager tutorial to note We'll put most of the effort towards improving support for grids in the next-gen CDMS. |
@jasonb5 the I don't have an example that I can immediately provide, but should be able to work one up. @jypeter I assume you have some examples somewhere? @pochedls? |
I don't have an example, but it could be useful to add an areacella variable in your test files, matching an existing CMIPn atmospheric variable already in the test files (don't remember if there is already a nicely CMORized variable in the test files) And then you can compute a global average (of 1 time step) using Or maybe use a normalized weight, in order to avoid potentially too big values Can also compare This could go to an averager notebook I'm a bit in a hurry, so I hope I have not written complete rubbish above! |
@jypeter I think that is a good idea, and I would add an ocean (non-cartesian) grid to the mix, so that the test case gets a little harder |
This example outlines the issue:
Migrated from: CDAT/cdat#402
The text was updated successfully, but these errors were encountered: