Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit fighting with itself. #2976

Open
1 of 3 tasks
JNygaard-Skylight opened this issue Dec 3, 2024 · 0 comments
Open
1 of 3 tasks

pre-commit fighting with itself. #2976

JNygaard-Skylight opened this issue Dec 3, 2024 · 0 comments
Labels
Streamline eCR Issues for Streamline eCR team to work on tech debt Technical debt related work

Comments

@JNygaard-Skylight
Copy link
Collaborator

Description

pre-commit appears to use different rules when ran locally and when ran in the Github pipeline. Example: This PR. In particular see commit b538b3f and commit d997b7a

Steps to reproduce

  1. Locally run `pre-commit run --all-files and commit changes
  2. Create a PR.
  3. pre-commit should then make autofixes that overwrite some of the changes made locally similar to the example above.

Expected Result

In the Github Actions pre-commit should not overwrite changes it makes locally.

Actual result

Github Actions pre-commit is overwriting changes it makes locally (see example above).

Priority

Provide an estimate for level of impact the bug has today by placing an X in the applicable bracket

Priority

  • Low priority The bug does not have to be fixed immediately. High and medium priority bugs should be addressed first.
  • Medium priority Typically, medium-priority bugs do not affect customers directly and therefore can be fixed in the normal course of testing and development.
  • High priority High priority bugs must be addressed immediately. They often affect the app’s functionality and impact customers and their user experience. They must take priority.
@JNygaard-Skylight JNygaard-Skylight added Streamline eCR Issues for Streamline eCR team to work on 🐛 bug Something isn't working tech debt Technical debt related work and removed 🐛 bug Something isn't working labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Streamline eCR Issues for Streamline eCR team to work on tech debt Technical debt related work
Projects
None yet
Development

No branches or pull requests

1 participant