Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate updates in CGAL 6.0 #270

Merged
merged 3 commits into from
May 29, 2024
Merged

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    80b01ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aeaa5c2 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. try to workaround a compilation issue with MSVC

    Maybe MSVC is confused by the name `Base`?
    
    https://github.com/CGAL/cgal-swig-bindings/actions/runs/9224622286/job/25380295698#step:9:272
    ```
      D:\a\cgal-swig-bindings\cgal-swig-bindings\SWIG_CGAL\AABB_tree\typedefs.h(30,3): error C2512: 'CGAL::AABB_halfedge_graph_segment_primitive<Polyhedron_3_,CGAL::Default,CGAL::Tag_true,CGAL::Tag_false>': no appropriate default constructor available [D:\a\cgal-swig-bindings\cgal-swig-bindings\build\SWIG_CGAL\AABB_tree\CGAL_AABB_tree_python.vcxproj]
    ```
    
    ```
      D:\a\cgal-swig-bindings\cgal-swig-bindings\SWIG_CGAL\AABB_tree\typedefs.h(29,7): error C2614: 'Primitive_wrapper<Polyhedron_3_,CGAL_PSP_base>': illegal member initialization: 'Base' is not a base or member [D:\a\cgal-swig-bindings\cgal-swig-bindings\build\SWIG_CGAL\AABB_tree\CGAL_AABB_tree_python.vcxproj]
    
    ```
    lrineau committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8562326 View commit details
    Browse the repository at this point in the history