Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of cmake_minimum_required #8699

Open
albert-github opened this issue Jan 17, 2025 · 0 comments
Open

Inconsistent use of cmake_minimum_required #8699

albert-github opened this issue Jan 17, 2025 · 0 comments

Comments

@albert-github
Copy link
Contributor

In the file Documentation/doc/CMakeLists.txt we see (like in other CMakeLists.txt files):

cmake_minimum_required(VERSION 3.12...3.29)

but now also the line:

cmake_minimum_required(VERSION 3.18..3.29) # for list(SORT ... COMPARE NATURAL)

has been added.

Either:

  • in the file Documentation/doc/CMakeLists.txt the first cmake_minimum_required line should be replaced by the second cmake_minimum_required line and the second cmake_minimum_required line should be removed

or

  • everywhere only the second cmake_minimum_required line should be used.

or

  • use second cmake_minimum_required line only in the top level CMakeLists.txt and remove all other occurrences of cmake_minimum_required (over 300 files).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant