diff --git a/extendr-api/src/robj/try_from_robj.rs b/extendr-api/src/robj/try_from_robj.rs index 01be22190a..f9256a9fea 100644 --- a/extendr-api/src/robj/try_from_robj.rs +++ b/extendr-api/src/robj/try_from_robj.rs @@ -26,6 +26,7 @@ macro_rules! impl_try_from_scalar_integer { // is problematic when converting a negative value to unsigned // integer types (e.g. `-1i32 as u8` becomes 255). if let Some(v) = robj.as_integer() { + //TODO: this needs to be `Ok(Self::from(v))` if let Ok(v) = Self::try_from(v) { return Ok(v); } else { diff --git a/xtask/src/commands/rextendr_document.rs b/xtask/src/commands/rextendr_document.rs index a7e44dcf6e..6598a65324 100644 --- a/xtask/src/commands/rextendr_document.rs +++ b/xtask/src/commands/rextendr_document.rs @@ -1,15 +1,15 @@ //! This invokes `rextendr::document()` within `tests/extendrtests`. -//! +//! //! It uses the vendored `rextendr` in the repository as the source package. -//! +//! //! 1. Ensure that `git submodule update --init` was invoked once, as to setup //! the vendored `rextendr` package. //! 2. `devtools` must be installed on system. -//! -//! +//! +//! //! The idea here is to be able to develop `rextendr` alongside `extendr`, //! as well as ease the development of extendr. -//! +//! use std::error::Error; use crate::extendrtests::with_absolute_path::{swap_extendr_api_path, R_FOLDER_PATH};