extendr-api: Implement R-internal by trait requirements,

not only for `Robj`.
CGMossa · Apr 6, 2024 · c14539b · c14539b
1 parent c23c6c6
commit c14539b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/extendr-api/src/io/load.rs b/extendr-api/src/io/load.rs
@@ -74,4 +74,4 @@ pub trait Load {
     }
 }
 
-impl Load for Robj {}
+impl<T: ?Sized> Load for T {}
diff --git a/extendr-api/src/io/save.rs b/extendr-api/src/io/save.rs
@@ -106,4 +106,4 @@ pub trait Save: GetSexp {
     }
 }
 
-impl<R: GetSexp> Save for R {}
+impl<T: ?Sized + GetSexp> Save for T {}
diff --git a/extendr-api/src/iter.rs b/extendr-api/src/iter.rs
@@ -201,7 +201,7 @@ pub trait AsStrIter: GetSexp + Types + Length + Attributes + Rinternals {
     }
 }
 
-impl AsStrIter for Robj {}
+impl<T: ?Sized + GetSexp + Types + Length + Attributes> AsStrIter for T {}
 
 impl TryFrom<&Robj> for StrIter {
     type Error = Error;

diff --git a/extendr-api/src/robj/mod.rs b/extendr-api/src/robj/mod.rs
@@ -760,7 +760,7 @@ pub trait Eval: GetSexp {
     }
 }
 
-impl Eval for Robj {}
+impl<T: ?Sized + GetSexp> Eval for T {}
 
 /// Generic access to typed slices in an Robj.
 pub trait AsTypedSlice<'a, T>
@@ -770,7 +770,9 @@ where
     fn try_into_typed_slice(&self) -> Result<&'a [T]>;
     fn try_into_typed_slice_mut(&mut self) -> Result<&'a mut [T]>;
 
+    #[deprecated]
     fn as_typed_slice(&self) -> Option<&'a [T]>;
+    #[deprecated]
     fn as_typed_slice_mut(&mut self) -> Option<&'a mut [T]>;
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -74,4 +74,4 @@ pub trait Load { @@
         }
     }
-    impl Load for Robj {}
+    impl<T: ?Sized> Load for T {}