Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #13 and ability to point at an external MKLShim #14

Open
colleeneb opened this issue Nov 1, 2024 · 1 comment
Open

PR #13 and ability to point at an external MKLShim #14

colleeneb opened this issue Nov 1, 2024 · 1 comment

Comments

@colleeneb
Copy link

PR #13 seems to have broken builds that want to point at an external MKLShim. That is,

git clone [email protected]:CHIP-SPV/H4I-HipSOLVER.git                                                                                                                                                                                             
cd H4I-HipSOLVER
mkdir build
cd build
MKL_DIR=$MKLROOT MKLShim_DIR=../../H4I-MKLShim/build/packages/ cmake -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DCMAKE_BUILD_TYPE=Release  -DCMAKE_INSTALL_PREFIX=$PWD/packages ..
make VERBOSE=1 install

Fails with

CMake Error at CMakeLists.txt:27 (add_subdirectory):
  add_subdirectory given source "H4I-MKLShim" which is not an existing
  directory.

Since it's expecting submodule mklshim to be there. Is there a reason? I like to pull MKLshim and then point HipBLAS and HipSOLVER to the same one, it seems unbalanced to have it as a submodule for the solver but not blas.

Thanks!

@colleeneb
Copy link
Author

Just pinging about this again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant