Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructing JSON string #3

Open
coleshaw opened this issue Sep 27, 2017 · 0 comments
Open

Constructing JSON string #3

coleshaw opened this issue Sep 27, 2017 · 0 comments

Comments

@coleshaw
Copy link
Contributor

In slideshowApp.es6.js, lines 1191-1233, you construct a JSON string, slidesJSON, manually. While I'm impressed that works, it also seems a bit complex / brittle....I think it would be more robust if you constructed slidesJSON as an object, and then ran it through JSON.stringify().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coleshaw