Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests #4

Open
coleshaw opened this issue Sep 27, 2017 · 0 comments
Open

Add some tests #4

coleshaw opened this issue Sep 27, 2017 · 0 comments

Comments

@coleshaw
Copy link
Contributor

I would recommend adding some sort of test suite to the app. For things like canvas, Webcam, or audio record methods, you can probably mock out the APIs or use sinon to make sure that the right methods are called (i.e. that this.video.pause() is called for the hideVideo method).

You've already broken stuff up really nicely into separate methods, so I would just say that tests for the important ones (ideally all) would help make sure the app is robust and probably catch some corner cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant