Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code in src/socket.io/index.js #113

Open
lynzhlang opened this issue Jan 22, 2025 · 2 comments · May be fixed by #161
Open

Refactoring code in src/socket.io/index.js #113

lynzhlang opened this issue Jan 22, 2025 · 2 comments · May be fixed by #161
Assignees
@lynzhlang

Comments

@lynzhlang
Copy link

lynzhlang commented Jan 22, 2025 •
edited
Loading

I am reducing cognitive complexity from 16 to 15 of the function onMessage. The function has many if statements which quickly add up in cognitive complexity. The code isn't very readable currently but adding helper functions could help readability greatly.
@lynzhlang
Copy link
Author

I would like to work on this please!

@github-actions GitHub Actions
Copy link

Great! I assigned you (@lynzhlang) to the issue. Have fun working on it!

@lynzhlang lynzhlang linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lynzhlang lynzhlang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored code in src/socket.io/index.js lynzhlang/NodeBB
1 participant
@lynzhlang