Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior between initial entry into waypoints and subsequent click #90

Closed
arwright opened this issue Sep 29, 2019 · 3 comments

Comments

@arwright
Copy link

arwright commented Sep 29, 2019

I have seen a number of times where the behavior differs between initially going to a waypoint vs clicking again on the same waypoint. I have seen this both with share links and with clicking on a waypoint from another waypoint within the same story.

Type 1:
Story type share link goes to a waypoint within a story that should show up with a dark background and some sort of data layers. Instead, when you first enter the story via the link it just shows landsat. Subsequently clicking on that same waypoint shows what it should.

I don't have an example handy, but this has happened a number of times and has caused problems in sending links to partners. I'll update this with a link next time I catch it doing this.

Type 2:
This happens with waypoints with a time range specified by bt/et that starts later than the overall layer time span: initial entry from another waypoint sets time position to the start of the layer time span instead of setting it to bt (as it should be). Subsequently clicking on the waypoint correctly sets the time to time position to bt.

Example:

  • Click on this waypoint
  • Click on the next waypoint to the right: Owner proximity, with bt=20090101&et=20180101

Correct behavior:

  • Time position should be 2009

Actual behavior:

  • Time position is 1951

This may be related to issue 60.

@rsargent
Copy link
Member

I've split "entering earthtime.org through a story sometimes doesn't display layers in first waypoint" (aka Type 1) off into bug #98

@pdille
Copy link
Contributor

pdille commented May 17, 2020

This should now be addressed in commit 40fc3e4 Please confirm.

@rsargent
Copy link
Member

Looks fixed! Tested at earthtime.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants