Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need to be able to define a mix of input files #153

Open
johannct opened this issue Jul 24, 2023 · 3 comments · May be fixed by #154
Open

we need to be able to define a mix of input files #153

johannct opened this issue Jul 24, 2023 · 3 comments · May be fixed by #154
Assignees
Milestone

Comments

@johannct
Copy link
Collaborator

johannct commented Jul 24, 2023

Whether objects come from RESSPECT simu, SNPCC, ELASTICC, etc..., surveys is not relevant anymore once they are read into light_curve objects. We need a factory kind of function that creates such a list of light_curve objects from a file listing in 2 columns which survey and a path corresponding to an object of this survey (the simplest API I can think of right now).
This will be useful for unit testing, but I see how to trivially import it in the library, not how to turn it into something that the python scripts can call (should still be straightforward)
This will also allow to make sure that the DB interface is agnostic to the survey specific file datasets.

@emilleishida
Copy link
Contributor

forget about the RESSPECT data set. Those were perfect sims that were used in the beginning only for first prototypes.
I do not believe they will be useful in the future

@johannct
Copy link
Collaborator Author

johannct commented Jul 24, 2023

is the related code planned for removal from the repository? Perfect sims handy may prove useful in future stages of code development, I would say....

@emilleishida
Copy link
Contributor

yes, it is planned for removal .. it has not been tested or updated for a long time
I guess that after we refactor everything it should be easier to add it again. But for now I am not sure if the effort necessary to test it and keep it up to date is worth the effort.

I already removed most of it, I can restore if that is the case, but I really do not think it is worth it

@johannct johannct linked a pull request Jul 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants