Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete documentation of rb-validate (formerly Runtime error in rb-validate) #3

Open
hmusta opened this issue Jun 12, 2018 · 3 comments

Comments

@hmusta
Copy link

hmusta commented Jun 12, 2018

I'm trying to benchmark query times for the color compressors in VARI and Rainbowfish and I get a runtime error while running rb-validate

cd kmcs
cosmo-build -d virus100_kmc2_list > virus100.cosmo.stdout.log 2> virus100.cosmo.stderr.log
pack-color virus100_kmc2_list.colors 100 406878400 4164666 > pack-color.stdout.log 2> pack-color.stderr.log
rb-pack-color virus100_kmc2_list.colors 100 virus100.rb 2pass > rbfish.stdout.log 2>rbfish.stderr.log
rb-validate virus100_kmc2_list.dbg virus100_kmc2_list.colors.sd_vector virus100.rb random-query
terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string::_M_construct null not valid
Aborted

Here's a link containing my input files and the run logs
https://drive.google.com/open?id=120nQqb10MyYs1dy2_vpwa8NvBX3YbFM_

IIRC, the only modifications I made to the code were increasing the maximum number of allowed colors to 1024 and the kmer size to 64 in the Makefile of VARI and CMakeLists.txt in Rainbowfish, and applying the patch to VARI (as described in its manual and source code) for working with this kmer size.

Thanks in advance for your help. Let me know if you need me to provide any additional info or logs.

@hmusta
Copy link
Author

hmusta commented Jun 12, 2018

After recompiling everything from scratch, I now get

rb-validate virus100_kmc2_list.dbg virus100_kmc2_list.colors.sd_vector virus100.rb cosmo-query
PARSE ERROR:  
             Required argument missing: validation_type

Brief USAGE: 
   /cluster/home/hmustafa/VARI/cosmo/rainbowfish/build/rb-validate  [--]
                                        [--version] [-h] <graph_file>
                                        <color_file> <res_dir> <bv_type>
                                        <validation_type>

For complete USAGE and HELP type: 
   /cluster/home/hmustafa/VARI/cosmo/rainbowfish/build/rb-validate --help

@hmusta
Copy link
Author

hmusta commented Jun 12, 2018

After looking through the code, it seems like the documentation is missing an argument that needs to be passed. The following runs without errors...

rb-validate virus100_kmc2_list.dbg virus100_kmc2_list.colors.sd_vector virus100.rb ucc random-query
5RBVec 15RBVecCompressed 15RBVecCompressed
pack-color compiled with supported colors=6000
loading dbg
loading colors
k             : 64
num_nodes()   : 4067291
num_edges()   : 4068784 or 692558
colors        : 100 or 100
Total size    : 1.0291 MB
Bits per edge : 2.1217 Bits
Is Label Length Dynamic? : 0
Label Fixed Length : 20
virus100.rb/lbl.bitvec -- size 13851160
Ran RBVec operator=
virus100.rb/eqTable.rrr -- size 67772700
Ran RBVecCompressed operator=
rb 0 s : 0 of 692558
rb 1 s : 0 of 692558





 Total of 69255800 comparisons with 173232 set bits:
                3722 ms : RAINBOWFISH
------------Some STATISTICS-------------
                select timing: 0 ms             getColor timing: 0 ms           getInt timing: 0 ms

@hmusta hmusta changed the title Runtime error in rb-validate Incomplete documentation of rb-validate (formerly Runtime error in rb-validate) Jun 12, 2018
@fataltes
Copy link
Collaborator

Hi @hmusta ,

Wow, you resolved your own posted issue then. I'll take a look at the validate code and update the readMe file respectively so that this doesn't happen again.

Thank you,
Fatemeh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants