-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The provided format of _atom_type.symbol
is ambiguous
#378
Comments
_atom_type.symbol
is ambiguous
I don't understand how this is ambiguous. The intention is that the type symbol is of the form The DDLm variant of the definition occurs in the earliest copies of the DDLm work that I have, from 2007, so I think it was an attempt to improve on the DDL1 definition, given that I assume that the point of If you can suggest a more precise definition that would be great. |
But doesn't the updated DDLm definition conflate the ideas of an atomic charge and oxidation state? How would the described "normal" code with an element symbol and a trailing charge look and how would it differ from the one with the oxidation state? |
Yes, it does conflate them. So |
This is the thing I would also like to find out. Consider the two examples: The However, note that the |
(prefix: I'm a physicist, so I think (or, at least, I thought I did) oxidation state and charge is the same thing) Just by way of example, when I'm modelling alpha-alumina, I use Al3+ and O2- scattering factors from Waasmair and Kirfel, but when I model silicon nitride, I use Si and N. What is the function of an In order to have different charge/oxidation combinations**, you would need to loop Other, related, data names are:
* I've just realised that I use ** Hooray! You've crystallised hydrogen peroxide hydrate! *** There are only two datanames that have |
Thank you for your insights! From a chemical standpoint (formal) charge and oxidation state are indeed not the same. However, in monoatomic ions they are. So would it be true to say that most crystallographic application operate under the assumption that the charge/oxidation state is only specified for monoatomic ions?
After thinking some more on this, I guess the different charge-oxidation state combinations could be recorded under the current setup using atom site codes like "O2-/a" and "O2-/b", e.g.:
|
It appears to me that I think it is reasonable to assume that atomic charges refer to monoatomic ions. I say this because the standard independent atom model assumed by current core CIF uses independent atoms, and the form factors chosen for those atoms are based on the charge of the independent atom. Perhaps we should emphasise this point, and advise that In general it would be good to clarify how the |
The issue is potentially related to issue #266.
The current definition of
_atom_type.symbol
reads:This seems a bit ambiguous since the code is described as
element symbol followed by the charge
while the later sentence states thatdigits designate an oxidation state
. The original DDL1 definition of this item omits the charge part and do not forbid spaces, but is otherwise virtually the same except that the charge part is omitted:The updated DDLm definition was already present in the first GitHub commit [1] so the exact origin of this change does not seem to be documented.
[1]
cif_core/core_struc.dic
Line 2400 in 3b24645
The text was updated successfully, but these errors were encountered: