Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL - Final dataset checks #39

Open
stephpenn1 opened this issue Feb 17, 2023 · 2 comments
Open

ALL - Final dataset checks #39

stephpenn1 opened this issue Feb 17, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@stephpenn1
Copy link
Member

stephpenn1 commented Feb 17, 2023

Go through each analyte and its code and make a graph of data and do visual checks

@amyerspigg
Copy link
Collaborator

VISUAL CHECKS MUST BE REFERENCES TO RANGES EXPECTED IN THE LITERATURE.

@amyerspigg
Copy link
Collaborator

amyerspigg commented Feb 24, 2023

Look through L1 code.

  • Are the calculations done in the script correct?
  • Are there gross coding things we need to change that we would be embarrassed about publishing?
  • Did we forget to do any steps (e.g. read in the read mes) ?
  • Are the data in the right units, and if presented in multiple units, are these relevant and clearly defined?
  • Are the flags applied correctly?
  • Are we missing any flags?
  • Are the data all there (Metadata Checks #38)?
  • Are there issues with sample names/data missing etc? (e.g. SOIL - K018 upland and wetland compromised #40 , MISSING LOI SAMPLES #43 )

If all of these are resolved for that data type, then write the L0B code.

Write into L2 (including #23)

Complete literature/visual checks

@stephpenn1 stephpenn1 changed the title Final dataset checks ALL - Final dataset checks Sep 13, 2023
@stephpenn1 stephpenn1 added the documentation Improvements or additions to documentation label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants