Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Collective Catalogue, searching by author institution not functioning #101

Closed
joedeville opened this issue Oct 18, 2023 · 4 comments
Closed
Assignees

Comments

@joedeville
Copy link
Collaborator

If it's not a quick fix, would it be possible to simply remove that functionality in the interim? We've had a university annoyed by it, so it'd be good to get it either hidden or fixed.

I'm imaginging it's related to Thoth updates?

@MartinPaulEve
Copy link
Collaborator

I think this is related to a recent change in the way that Thoth represents institutions and our data is now very bad on this, as the importer is not picking this up. This is also causing some of the problems in #52

Will have to rewrite the importer to use the new format.

We also need to have a conversation with Thoth -- if their API is not stable, then we will continue to hit these kind of bugs that cause us breakage.

@MartinPaulEve
Copy link
Collaborator

Raised related, but not causal, bug on Thoth thoth-pub/thoth#518

@MartinPaulEve
Copy link
Collaborator

Bug triaged:

  • Bug is in the sync feature from Thoth, not in search. Institutional affiliations were not being synced since the Thoth update.
  • The sync function was only pulling the first 9999 entries from Thoth. There are actually more than 100k.
  • If we add these manually in the try/catch block, the orphaned institution cleaner removes them.

@MartinPaulEve
Copy link
Collaborator

Fixed in COPIM/intrepid@de0ac95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants