Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor : Refactored the tweets section in home #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor : Refactored the tweets section in home #19

wants to merge 1 commit into from

Conversation

MeherRushi
Copy link

@MeherRushi MeherRushi commented Aug 6, 2024 •
edited
Loading

  • Since the Twitter API has been changed to paid, we manually fetch tweets using the embedded code feature provided for temporary basis
  • Removed the old code and refactored the twitter div
  • Made tweet height changes and added minimalistic scroll bar
  • also formatted the tweets.json file

This also fixes #15

@MeherRushi
refactor : Refactored the tweets section in home
bc13ffa 
- Since the Twitter API has been changed to paid, we maunually
 fetch tweets using the embedded code feature provided for temporary basis
- Removed the old code and refactored the twitter div
- Made tweet height changes and added minimalistic scroll bar
@aadilkhalifa
Copy link
Member

@MeherRushi Can you attach screenshots

@MeherRushi
Copy link
Author

MeherRushi commented Aug 6, 2024 •
edited
Loading

Yup sure. Sorry forgot to do it before
image

@aadilkhalifa
Copy link
Member

Would suggest to get rid of the scrollbar and make the height of the card fit the content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Twitter card images not loading
2 participants
@MeherRushi @aadilkhalifa