Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Abstract away depunctuation in python scripts #706

Open
1 of 2 tasks
SomeMoosery opened this issue May 13, 2020 · 2 comments
Open
1 of 2 tasks

[FEAT] Abstract away depunctuation in python scripts #706

SomeMoosery opened this issue May 13, 2020 · 2 comments
Assignees
@mayankkt9
Labels
good first issue Good for newcomers tech debt

Comments

@SomeMoosery
Copy link
Member

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

  • check this box if you have completed the following:
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Summary

  • there are multiple instances within the python scripts where we depunctuate data (i.e. replacing '.' with ''). Abstract this into a common util function depunctuate(...)

Motivation

Code clarity and quality
@SomeMoosery SomeMoosery added good first issue Good for newcomers help wanted Extra attention is needed tech debt labels May 13, 2020
@mayankkt9
Copy link

Can I work on this ?

@SomeMoosery
Copy link
Member Author

All you 👍

@SomeMoosery SomeMoosery removed the help wanted Extra attention is needed label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayankkt9 mayankkt9

Labels
good first issue Good for newcomers tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SomeMoosery @mayankkt9