Add support for "fractional gates" #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-melf
reviewed
Jan 22, 2025
| return {OpType.X, OpType.SX, OpType.Rz, OpType.ECR} | ||
| else: | ||
| return gateset | ||
| return gateset & (ALL_PRIMITIVE_1Q_GATES | ALL_PRIMITIVE_2Q_GATES) |
There was a problem hiding this comment.
Is there anything unexpected happening if gateset contains CX and ECR?
There was a problem hiding this comment.
I don't think this should be a problem. In fact it looks like none of the devices have CX any more; they use CZ instead, though never in combination with ECR. With fractional gates some devices have both CZ and ZZPhase. This doesn't seem to cause any issues.
cqc-melf
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #413 .
The test failure is unrelated: see #449 .
It is not currently possible to add a CI test for this as none of the devices on the open plan support fractional gates. But I have tested locally with
ibm_torino.In addition, I have added a squashing step to the default compilation passes, since they were not squashing single-qubit gates (as pointed out in the comments on the issue).