By: W10-B2
Since: Jun 2016
Licence: MIT
- 1. Setting up
- 2. Design
- 3. Implementation
- 3.1. Lock/unlock & reset password feature
- 3.2. SortCommand feature
- 3.3. ExportCommand feature
- 3.4. ListAppointment feature
- 3.5. DeleteTag feature
- 3.6. AddComment feature
- 3.7. Archive feature
- 3.8. Switch theme feature
- 3.9. Appointments feature
- 3.10. TimeZone feature
- 3.11. Email feature
- 3.12. Undo/Redo feature
- 3.13. [Proposed] Data Encryption
- 3.14. Logging
- 3.15. Configuration
- 4. Documentation
- 5. Testing
- 6. Dev Ops
- Appendix A: Suggested Programming Tasks to Get Started
- Appendix B: Product Scope
- Appendix C: User Stories
- Appendix D: Use Cases
- Appendix E: Non Functional Requirements
- Appendix F: Glossary
- Appendix G: Product Survey
- Appendix H: Instructions for Manual Testing
- H.1. Launch and Shutdown
- H.2. Deleting a person
- H.3. Add appointment
- H.4. Delete appointment
- H.5. Edit appointment
- H.6. Archive client
- H.7. List all clients
- H.8. Unarchive client
- H.9. Switch theme
- H.10. Lock
- H.11. Unlock
- H.12. Change Password
- H.13. List all appointments
- H.14. Sort all contacts
- H.15. Remove tags from all contacts
- H.16. Export all contacts
- H.17. Add comments to contacts
- H.18. Incorrect time zones are rejected
- H.19. Send an email to a client
- H.20. Reply to an client email
- H.21. Forward a client email
- H.22. Load all client emails.
- H.23. Receive a client email
- H.24. Saving data
-
JDK
1.8.0_60
or laterℹ️Having any Java 8 version is not enough.
This app will not work with earlier versions of Java 8. -
IntelliJ IDE
ℹ️IntelliJ by default has Gradle and JavaFx plugins installed.
Do not disable them. If you have disabled them, go toFile
>Settings
>Plugins
to re-enable them.
-
Fork this repo, and clone the fork to your computer
-
Open IntelliJ (if you are not in the welcome screen, click
File
>Close Project
to close the existing project dialog first) -
Set up the correct JDK version for Gradle
-
Click
Configure
>Project Defaults
>Project Structure
-
Click
New…
and find the directory of the JDK
-
-
Click
Import Project
-
Locate the
build.gradle
file and select it. ClickOK
-
Click
Open as Project
-
Click
OK
to accept the default settings -
Open a console and run the command
gradlew processResources
(Mac/Linux:./gradlew processResources
). It should finish with theBUILD SUCCESSFUL
message.
This will generate all resources required by the application and tests.
-
Run the
seedu.address.MainApp
and try a few commands -
Run the tests to ensure they all pass.
This project follows oss-generic coding standards. IntelliJ’s default style is mostly compliant with ours but it uses a different import order from ours. To rectify,
-
Go to
File
>Settings…
(Windows/Linux), orIntelliJ IDEA
>Preferences…
(macOS) -
Select
Editor
>Code Style
>Java
-
Click on the
Imports
tab to set the order-
For
Class count to use import with '*'
andNames count to use static import with '*'
: Set to999
to prevent IntelliJ from contracting the import statements -
For
Import Layout
: The order isimport static all other imports
,import java.*
,import javax.*
,import org.*
,import com.*
,import all other imports
. Add a<blank line>
between eachimport
-
Optionally, you can follow the UsingCheckstyle.adoc document to configure Intellij to check style-compliance as you write code.
After forking the repo, links in the documentation will still point to the se-edu/addressbook-level4
repo. If you plan to develop this as a separate product (i.e. instead of contributing to the se-edu/addressbook-level4
) , you should replace the URL in the variable repoURL
in DeveloperGuide.adoc
and UserGuide.adoc
with the URL of your fork.
Set up Travis to perform Continuous Integration (CI) for your fork. See UsingTravis.adoc to learn how to set it up.
After setting up Travis, you can optionally set up coverage reporting for your team fork (see UsingCoveralls.adoc).
ℹ️
|
Coverage reporting could be useful for a team repository that hosts the final version but it is not that useful for your personal fork. |
Optionally, you can set up AppVeyor as a second CI (see UsingAppVeyor.adoc).
ℹ️
|
Having both Travis and AppVeyor ensures your App works on both Unix-based platforms and Windows-based platforms (Travis is Unix-based and AppVeyor is Windows-based) |
When you are ready to start coding,
-
Get some sense of the overall design by reading Section 2.1, “Architecture”.
-
Take a look at Appendix A, Suggested Programming Tasks to Get Started.
The Architecture Diagram given above explains the high-level design of the App. Given below is a quick overview of each component.
💡
|
The .pptx files used to create diagrams in this document can be found in the diagrams folder. To update a diagram, modify the diagram in the pptx file, select the objects of the diagram, and choose Save as picture .
|
Main
has only one class called MainApp
. It is responsible for,
-
At app launch: Initializes the components in the correct sequence, and connects them up with each other.
-
At shut down: Shuts down the components and invokes cleanup method where necessary.
Commons
represents a collection of classes used by multiple other components. Two of those classes play important roles at the architecture level.
-
EventsCenter
: This class (written using Google’s Event Bus library) is used by components to communicate with other components using events (i.e. a form of Event Driven design) -
LogsCenter
: Used by many classes to write log messages to the App’s log file.
The rest of the App consists of four components.
Each of the four components
-
Defines its API in an
interface
with the same name as the Component. -
Exposes its functionality using a
{Component Name}Manager
class.
For example, the Logic
component (see the class diagram given below) defines it’s API in the Logic.java
interface and exposes its functionality using the LogicManager.java
class.
The Sequence Diagram below shows how the components interact for the scenario where the user issues the command delete 1
.
ℹ️
|
Note how the Model simply raises a AddressBookChangedEvent when the Address Book data are changed, instead of asking the Storage to save the updates to the hard disk.
|
The diagram below shows how the EventsCenter
reacts to that event, which eventually results in the updates being saved to the hard disk and the status bar of the UI being updated to reflect the 'Last Updated' time.
ℹ️
|
Note how the event is propagated through the EventsCenter to the Storage and UI without Model having to be coupled to either of them. This is an example of how this Event Driven approach helps us reduce direct coupling between components.
|
The sections below give more details of each component.
API : Ui.java
The UI consists of a MainWindow
that is made up of parts e.g.CommandBox
, ResultDisplay
, PersonListPanel
, StatusBarFooter
, BrowserPanel
etc. All these, including the MainWindow
, inherit from the abstract UiPart
class.
The UI
component uses JavaFx UI framework. The layout of these UI parts are defined in matching .fxml
files that are in the src/main/resources/view
folder. For example, the layout of the MainWindow
is specified in MainWindow.fxml
The UI
component,
-
Executes user commands using the
Logic
component. -
Binds itself to some data in the
Model
so that the UI can auto-update when data in theModel
change. -
Responds to events raised from various parts of the App and updates the UI accordingly.
XYZCommand
and Command
in Figure 6, “Structure of the Logic Component”API :
Logic.java
-
Logic
uses theAddressBookParser
class to parse the user command. -
This results in a
Command
object which is executed by theLogicManager
. -
The command execution can affect the
Model
(e.g. adding a person) and/or raise events. -
The result of the command execution is encapsulated as a
CommandResult
object which is passed back to theUi
.
Given below is the Sequence Diagram for interactions within the Logic
component for the execute("delete 1")
API call.
API : Model.java
The Model
,
-
stores a
UserPref
object that represents the user’s preferences. -
stores the Address Book data.
-
exposes an unmodifiable
ObservableList<Person>
that can be 'observed' e.g. the UI can be bound to this list so that the UI automatically updates when the data in the list change. -
does not depend on any of the other three components.
API : Storage.java
The Storage
component,
-
can save
UserPref
objects in json format and read it back. -
can save the Address Book data in xml format and read it back.
This section describes some noteworthy details on how certain features are implemented.
The lock/unlock command feature requires the sales person to enter password whenever he/she starts to modify the addressbook. This will allow for a safer address book.
To lock the adress book, simply type 'lock' or the command alias 'lk'.
An example of the sort command would be: lock
An example of the sort command alias would be: lk
To unlock the adress book, simply type 'unlock PASSWORD' or the command alias 'ulk PASSWORD'.
An example of the sort command would be: unlock 123456
An example of the sort command alias would be: ulk 123456
The reset password command feature allows the sales person to change password. This will allow for a safer address book.
To change the password, simply type 'setPassword OLD_PASSWORD NEW_PASSWORD' or the command alias 'sp OLD_PASSWORD NEW_PASSWORD'.
An example of the change password command would be: setPassword 123456 123
An example of the sort command alias would be: sp 123456 123
-
Alternative 1 (current choice): After unlocking, the content at contact and appointment panel remain unshown, list/listall/listappointment comand are needed.
-
Pros: User can only list the content they want with flexibility.
-
Cons: One more command is needed, it might be a little bit complex.
-
-
Alternative 2: After unlocking, the content at contact and appointment panel show automatically.
-
Pros: Less action and command are needed.
-
Cons: User can not hide the content they don’t want to show
-
The sort command feature allows the sales person to sort their clients according to their names in alphebetical order. This will allow for a more organized and neat address book.
To sort the adress book, simply type 'sort' or the command alias 'so'.
An example of the sort command would be: sort
An example of the sort command alias would be: so
The export command feature allows the sales person to export their clients to a csv file. This will allow for a more organized and neat address book.
To export the adress book, simply type 'export' or the command alias 'ep'.
An example of the sort command would be: export
An example of the sort command alias would be: ep
The listappointment command feature allows the sales person to list all the appointments in his addressbook. This will allow for a more simple way to fina an appointment.
To list the appointment in the adress book, simply type 'listappointment' or the command alias 'lap'.
An example of the sort command would be: listappointment
An example of the sort command alias would be: lap
The delete tag command allows user to remove a particular tag from all persons in the AddressBook. For example, he may want to delete the tag "neigbour" from all his contacts if he is no longer staying at the place.
To delete a tag, simply type 'deletetag [TAG]' or the command alias 'dt [TAG]'.
An example of the delete tag command would be: deletetag firends
An example of the sort command alias would be: dt friends
The current codebase has a flaw in tags management. Tags no longer in use by anyone may still exist on the AddressBook. This may cause some tests to fail.
-
Alternative 1 (current choice): After updating a person, we go through everyone in the address book and collect their tags.
-
Pros: No more unused tags.
-
Cons: The time complexity is too high, of O(n^2).
-
-
Alternative 2: When deleting a tag, check whether there are person still having it as a tag.
-
Pros: Less time consuming.
-
Cons: More complex inplementation.
-
The add comment tag command will allow user to add some plain text information associated with a contact that the user wants to remember, so that I can recall it when I need the information.
To add the comment of a client, the cm/ tag is used with either the add or edit commands, followed by the comment.
An example of the add command would be: add n/David … cm/interested in football
An example of the edit command would be: edit 1 cm/interested in bascketball
-
Alternative 1 (current choice): User must add comment when adding client.
-
Pros: Information consistency.
-
Cons: User may not always want to add comment to clients.
-
-
Alternative 2: User can optionally add the comments in a separate command.
-
Pros: Will use less memory (e.g. number of comments are less than or equal to number of users).
-
Cons: May be more difficult to manage contacts without some comments.
-
The archive feature allows the salesperson to archive clients that he no longer contacts, but does not want to delete as he possibly might want to contact him/her again. Once archived, the client is not shown in the list. To display the client, either find
or listall
command has to be used. The client is then displayed in a red font with strikethrough, indicating that he/she is archived.
The archival feature is implemented by adding a boolean variable isArchived
in the Person model. Listing is filtered through the use of a predicate, PREDICATE_SHOW_UNARCHIVED_PERSONS
, that will filter for those clients that are unarchived
-
Alternative 1 (current choice): Find shows archived clients.
-
Pros: Allows the user to quickly find specific clients that he wants to unarchive.
-
Cons: Goes against the purpose of not cluttering up the UI with archived clients.
-
-
Alternative 2: Find only displays unarchived clients.
-
Pros: Will not clutter up the UI with archived clients so that the user can quickly find clients that are unarchived.
-
Cons: It is hard to find a specific archived person. User has to scroll through listall.
-
-
Alternative 1 (current choice): Store whether a client is archived in the Person model as a boolean
-
Pros: Simple to implement
-
Cons: Uses more space than the alternative.
-
-
Alternative 2: Keep two separate lists of persons, archived and unarchived.
-
Pros: Uses less space than the alternative.
-
Cons: Harder to implement, more changes have to be made to existing codebase.
-
The switch theme feature allows the salesperson to switch between dark and light thenmes as he might have to work under different lighting conditions. The theme that is in used persists across restarts
See sequence diagram. The archival feature is implemented by triggering an SwitchThemeRequestEvent()
which is then handled in MainWindow
.
The theme switching in done in two ways. For the main window, it is done by changing the CSS stylesheet used. For the calendar, because the stylesheet is complicated and is provided by an external library, we use a JavaFX effect to invert all colors.
-
Alternative 1 (current choice): Theme switching is triggered by an event
-
Pros: Preserves modularity, and Separation of Concerns.
-
Cons: More code.
-
-
Alternative 2: Theme switching happens directly in switch theme command
-
Pros: Simpler.
-
Cons: Breaks modularity and Separations of Concerns. UI should be handled in the UI section not the Logic section.
-
-
Alternative 1 (current choice): Calender theme swithing is handled by JavaFX effect
-
Pros: Simple to implement
-
Cons: Potentially ugly and less flexible, as cannot configure the individual colours.
-
-
Alternative 2: Create another calendar CSS for the dark theme
-
Pros: More flexible in choice of colors, resulting in more beautiful UI.
-
Cons: Difficult to implement, due to complexity of CSS stylesheet.
-
Cons: Loses color consistency of simply inverting colors.
-
Cons: Any future change in colors have to update two stylesheets.
-
The appointments feature allows the salesperson to add and edit appointments that he have with clients in the contact list. He can also view the appointments in a calendar.
The edit appointment feature is interesting in that editing persons check whether the person is already in the appointment. If so, the person is removed. Otherwise, the person is added. This differs from the behaviour of editing tags of a person, which is destructive and overwrite all tags.
-
Alternative 1 (current choice): Editing an appointment’s person list adds the person if not present and removes the person otherwise.
-
Pros: Fits the usual use case of a person saying he is/is unable to make it for the appointment
-
Cons: Cannot overwrite the person list with a new set of persons directly.
-
-
Alternative 2: Destructively edit the person list, replacing it with the new list.
-
Pros: Easier to overwrite the person list.
-
Cons: Does not fit the expected use case
-
-
Alternative 1 (current choice): Calender is handled by external library, CalendarFX
-
Pros: Less effort, make good use of existing code to reduce duplication of effort.
-
Cons: Calendar is less customisable. Limited to what is already implemented.
-
-
Alternative 2: Create our own calendar
-
Pros: More flexible terms of how the calendar will work
-
Cons: More effort. Time could be used on other features.
-
The time zone feature allows the sales person to add a time zone for their clients. This will allow for simplified appointment scheduling between the sales person and their international clients.
To add the time zone of a client, the tz/ tag is used with either the add or edit commands, followed by the time zone.
An example of the add command would be: add n/David … tz/PST
An example of the edit command would be: edit 1 tz/SGT
-
Alternative 1 (current choice): User must add time zone when adding client.
-
Pros: Information consistency.
-
Cons: User may not always know client’s time zone.
-
-
Alternative 2: User can optionally add the time zone in a separate command.
-
Pros: Will use less memory (e.g. number of time zones are less than or equal to number of users).
-
Cons: May be more difficult to schedule meetings with clients with unknown time zones.
-
The email feature allows the user to send emails in the app by typing their message in an email compose pop up box. The inbox feature allows the user to see a preview of the plain text emails that they have received right when they open the app. To view the message, the user clicks the message and an popup will appear with the full message.
-
Alternative 1 (current choice): Display the inbox panel so that it can be seen right when the user opens Sell IT.
-
Pros: Convenient and saves time which are key aspects as the user is a busy sales person.
-
Cons: May clutter up the app’s start page.
-
-
Alternative 2: Inbox can be displayed on a separate panel which can be accessed by the user through a mail icon button.
-
Pros: Less clutter
-
Cons: May be less convenient for the sales person to always need to click the button to view their inbox.
-
The undo/redo mechanism is facilitated by an UndoRedoStack
, which resides inside LogicManager
. It supports undoing and redoing of commands that modifies the state of the address book (e.g. add
, edit
). Such commands will inherit from UndoableCommand
.
UndoRedoStack
only deals with UndoableCommands
. Commands that cannot be undone will inherit from Command
instead. The following diagram shows the inheritance diagram for commands:
As you can see from the diagram, UndoableCommand
adds an extra layer between the abstract Command
class and concrete commands that can be undone, such as the DeleteCommand
. Note that extra tasks need to be done when executing a command in an undoable way, such as saving the state of the address book before execution. UndoableCommand
contains the high-level algorithm for those extra tasks while the child classes implements the details of how to execute the specific command. Note that this technique of putting the high-level algorithm in the parent class and lower-level steps of the algorithm in child classes is also known as the template pattern.
Commands that are not undoable are implemented this way:
public class ListCommand extends Command {
@Override
public CommandResult execute() {
// ... list logic ...
}
}
With the extra layer, the commands that are undoable are implemented this way:
public abstract class UndoableCommand extends Command {
@Override
public CommandResult execute() {
// ... undo logic ...
executeUndoableCommand();
}
}
public class DeleteCommand extends UndoableCommand {
@Override
public CommandResult executeUndoableCommand() {
// ... delete logic ...
}
}
Suppose that the user has just launched the application. The UndoRedoStack
will be empty at the beginning.
The user executes a new UndoableCommand
, delete 5
, to delete the 5th person in the address book. The current state of the address book is saved before the delete 5
command executes. The delete 5
command will then be pushed onto the undoStack
(the current state is saved together with the command).
As the user continues to use the program, more commands are added into the undoStack
. For example, the user may execute add n/David …
to add a new person.
ℹ️
|
If a command fails its execution, it will not be pushed to the UndoRedoStack at all.
|
The user now decides that adding the person was a mistake, and decides to undo that action using undo
.
We will pop the most recent command out of the undoStack
and push it back to the redoStack
. We will restore the address book to the state before the add
command executed.
ℹ️
|
If the undoStack is empty, then there are no other commands left to be undone, and an Exception will be thrown when popping the undoStack .
|
The following sequence diagram shows how the undo operation works:
The redo does the exact opposite (pops from redoStack
, push to undoStack
, and restores the address book to the state after the command is executed).
ℹ️
|
If the redoStack is empty, then there are no other commands left to be redone, and an Exception will be thrown when popping the redoStack .
|
The user now decides to execute a new command, clear
. As before, clear
will be pushed into the undoStack
. This time the redoStack
is no longer empty. It will be purged as it no longer make sense to redo the add n/David
command (this is the behavior that most modern desktop applications follow).
Commands that are not undoable are not added into the undoStack
. For example, list
, which inherits from Command
rather than UndoableCommand
, will not be added after execution:
The following activity diagram summarize what happens inside the UndoRedoStack
when a user executes a new command:
-
Alternative 1 (current choice): Add a new abstract method
executeUndoableCommand()
-
Pros: We will not lose any undone/redone functionality as it is now part of the default behaviour. Classes that deal with
Command
do not have to know thatexecuteUndoableCommand()
exist. -
Cons: Hard for new developers to understand the template pattern.
-
-
Alternative 2: Just override
execute()
-
Pros: Does not involve the template pattern, easier for new developers to understand.
-
Cons: Classes that inherit from
UndoableCommand
must remember to callsuper.execute()
, or lose the ability to undo/redo.
-
-
Alternative 1 (current choice): Saves the entire address book.
-
Pros: Easy to implement.
-
Cons: May have performance issues in terms of memory usage.
-
-
Alternative 2: Individual command knows how to undo/redo by itself.
-
Pros: Will use less memory (e.g. for
delete
, just save the person being deleted). -
Cons: We must ensure that the implementation of each individual command are correct.
-
-
Alternative 1 (current choice): Only include commands that modifies the address book (
add
,clear
,edit
).-
Pros: We only revert changes that are hard to change back (the view can easily be re-modified as no data are * lost).
-
Cons: User might think that undo also applies when the list is modified (undoing filtering for example), * only to realize that it does not do that, after executing
undo
.
-
-
Alternative 2: Include all commands.
-
Pros: Might be more intuitive for the user.
-
Cons: User have no way of skipping such commands if he or she just want to reset the state of the address * book and not the view. Additional Info: See our discussion here.
-
-
Alternative 1 (current choice): Use separate stack for undo and redo
-
Pros: Easy to understand for new Computer Science student undergraduates to understand, who are likely to be * the new incoming developers of our project.
-
Cons: Logic is duplicated twice. For example, when a new command is executed, we must remember to update * both
HistoryManager
andUndoRedoStack
.
-
-
Alternative 2: Use
HistoryManager
for undo/redo-
Pros: We do not need to maintain a separate stack, and just reuse what is already in the codebase.
-
Cons: Requires dealing with commands that have already been undone: We must remember to skip these commands. Violates Single Responsibility Principle and Separation of Concerns as
HistoryManager
now needs to do two * different things.
-
We are using java.util.logging
package for logging. The LogsCenter
class is used to manage the logging levels and logging destinations.
-
The logging level can be controlled using the
logLevel
setting in the configuration file (See Section 3.15, “Configuration”) -
The
Logger
for a class can be obtained usingLogsCenter.getLogger(Class)
which will log messages according to the specified logging level -
Currently log messages are output through:
Console
and to a.log
file.
Logging Levels
-
SEVERE
: Critical problem detected which may possibly cause the termination of the application -
WARNING
: Can continue, but with caution -
INFO
: Information showing the noteworthy actions by the App -
FINE
: Details that is not usually noteworthy but may be useful in debugging e.g. print the actual list instead of just its size
We use asciidoc for writing documentation.
ℹ️
|
We chose asciidoc over Markdown because asciidoc, although a bit more complex than Markdown, provides more flexibility in formatting. |
See UsingGradle.adoc to learn how to render .adoc
files locally to preview the end result of your edits.
Alternatively, you can download the AsciiDoc plugin for IntelliJ, which allows you to preview the changes you have made to your .adoc
files in real-time.
See UsingTravis.adoc to learn how to deploy GitHub Pages using Travis.
We use Google Chrome for converting documentation to PDF format, as Chrome’s PDF engine preserves hyperlinks used in webpages.
Here are the steps to convert the project documentation files to PDF format.
-
Follow the instructions in UsingGradle.adoc to convert the AsciiDoc files in the
docs/
directory to HTML format. -
Go to your generated HTML files in the
build/docs
folder, right click on them and selectOpen with
→Google Chrome
. -
Within Chrome, click on the
Print
option in Chrome’s menu. -
Set the destination to
Save as PDF
, then clickSave
to save a copy of the file in PDF format. For best results, use the settings indicated in the screenshot below.
There are three ways to run tests.
💡
|
The most reliable way to run tests is the 3rd one. The first two methods might fail some GUI tests due to platform/resolution-specific idiosyncrasies. |
Method 1: Using IntelliJ JUnit test runner
-
To run all tests, right-click on the
src/test/java
folder and chooseRun 'All Tests'
-
To run a subset of tests, you can right-click on a test package, test class, or a test and choose
Run 'ABC'
Method 2: Using Gradle
-
Open a console and run the command
gradlew clean allTests
(Mac/Linux:./gradlew clean allTests
)
ℹ️
|
See UsingGradle.adoc for more info on how to run tests using Gradle. |
Method 3: Using Gradle (headless)
Thanks to the TestFX library we use, our GUI tests can be run in the headless mode. In the headless mode, GUI tests do not show up on the screen. That means the developer can do other things on the Computer while the tests are running.
To run tests in headless mode, open a console and run the command gradlew clean headless allTests
(Mac/Linux: ./gradlew clean headless allTests
)
We have two types of tests:
-
GUI Tests - These are tests involving the GUI. They include,
-
System Tests that test the entire App by simulating user actions on the GUI. These are in the
systemtests
package. -
Unit tests that test the individual components. These are in
seedu.address.ui
package.
-
-
Non-GUI Tests - These are tests not involving the GUI. They include,
-
Unit tests targeting the lowest level methods/classes.
e.g.seedu.address.commons.StringUtilTest
-
Integration tests that are checking the integration of multiple code units (those code units are assumed to be working).
e.g.seedu.address.storage.StorageManagerTest
-
Hybrids of unit and integration tests. These test are checking multiple code units as well as how the are connected together.
e.g.seedu.address.logic.LogicManagerTest
-
See UsingGradle.adoc to learn how to use Gradle for build automation.
We use Travis CI and AppVeyor to perform Continuous Integration on our projects. See UsingTravis.adoc and UsingAppVeyor.adoc for more details.
We use Coveralls to track the code coverage of our projects. See UsingCoveralls.adoc for more details.
When a pull request has changes to asciidoc files, you can use Netlify to see a preview of how the HTML version of those asciidoc files will look like when the pull request is merged. See UsingNetlify.adoc for more details.
Here are the steps to create a new release.
-
Update the version number in
MainApp.java
. -
Generate a JAR file using Gradle.
-
Tag the repo with the version number. e.g.
v0.1
-
Create a new release using GitHub and upload the JAR file you created.
A project often depends on third-party libraries. For example, Address Book depends on the Jackson library for XML parsing. Managing these dependencies can be automated using Gradle. For example, Gradle can download the dependencies automatically, which is better than these alternatives.
a. Include those libraries in the repo (this bloats the repo size)
b. Require developers to download those libraries manually (this creates extra work for developers)
Suggested path for new programmers:
-
First, add small local-impact (i.e. the impact of the change does not go beyond the component) enhancements to one component at a time. Some suggestions are given in Section A.1, “Improving each component”.
-
Next, add a feature that touches multiple components to learn how to implement an end-to-end feature across all components. Section A.2, “Creating a new command:
remark
” explains how to go about adding such a feature.
Each individual exercise in this section is component-based (i.e. you would not need to modify the other components to get it to work).
Scenario: You are in charge of logic
. During dog-fooding, your team realize that it is troublesome for the user to type the whole command in order to execute a command. Your team devise some strategies to help cut down the amount of typing necessary, and one of the suggestions was to implement aliases for the command words. Your job is to implement such aliases.
💡
|
Do take a look at Section 2.3, “Logic component” before attempting to modify the Logic component.
|
-
Add a shorthand equivalent alias for each of the individual commands. For example, besides typing
clear
, the user can also typec
to remove all persons in the list.-
Hints
-
Just like we store each individual command word constant
COMMAND_WORD
inside*Command.java
(e.g.FindCommand#COMMAND_WORD
,DeleteCommand#COMMAND_WORD
), you need a new constant for aliases as well (e.g.FindCommand#COMMAND_ALIAS
). -
AddressBookParser
is responsible for analyzing command words.
-
-
Solution
-
Modify the switch statement in
AddressBookParser#parseCommand(String)
such that both the proper command word and alias can be used to execute the same intended command. -
Add new tests for each of the aliases that you have added.
-
Update the user guide to document the new aliases.
-
See this PR for the full solution.
-
-
Scenario: You are in charge of model
. One day, the logic
-in-charge approaches you for help. He wants to implement a command such that the user is able to remove a particular tag from everyone in the address book, but the model API does not support such a functionality at the moment. Your job is to implement an API method, so that your teammate can use your API to implement his command.
💡
|
Do take a look at Section 2.4, “Model component” before attempting to modify the Model component.
|
-
Add a
removeTag(Tag)
method. The specified tag will be removed from everyone in the address book.-
Hints
-
The
Model
and theAddressBook
API need to be updated. -
Think about how you can use SLAP to design the method. Where should we place the main logic of deleting tags?
-
Find out which of the existing API methods in
AddressBook
andPerson
classes can be used to implement the tag removal logic.AddressBook
allows you to update a person, andPerson
allows you to update the tags.
-
-
Solution
-
Implement a
removeTag(Tag)
method inAddressBook
. Loop through each person, and remove thetag
from each person. -
Add a new API method
deleteTag(Tag)
inModelManager
. YourModelManager
should callAddressBook#removeTag(Tag)
. -
Add new tests for each of the new public methods that you have added.
-
See this PR for the full solution.
-
The current codebase has a flaw in tags management. Tags no longer in use by anyone may still exist on the
AddressBook
. This may cause some tests to fail. See issue#753
for more information about this flaw. -
The solution PR has a temporary fix for the flaw mentioned above in its first commit.
-
-
-
Scenario: You are in charge of ui
. During a beta testing session, your team is observing how the users use your address book application. You realize that one of the users occasionally tries to delete non-existent tags from a contact, because the tags all look the same visually, and the user got confused. Another user made a typing mistake in his command, but did not realize he had done so because the error message wasn’t prominent enough. A third user keeps scrolling down the list, because he keeps forgetting the index of the last person in the list. Your job is to implement improvements to the UI to solve all these problems.
💡
|
Do take a look at Section 2.2, “UI component” before attempting to modify the UI component.
|
-
Use different colors for different tags inside person cards. For example,
friends
tags can be all in brown, andcolleagues
tags can be all in yellow.Before
After
-
Hints
-
The tag labels are created inside the
PersonCard
constructor (new Label(tag.tagName)
). JavaFX’sLabel
class allows you to modify the style of each Label, such as changing its color. -
Use the .css attribute
-fx-background-color
to add a color. -
You may wish to modify
DarkTheme.css
to include some pre-defined colors using css, especially if you have experience with web-based css.
-
-
Solution
-
You can modify the existing test methods for
PersonCard
's to include testing the tag’s color as well. -
See this PR for the full solution.
-
The PR uses the hash code of the tag names to generate a color. This is deliberately designed to ensure consistent colors each time the application runs. You may wish to expand on this design to include additional features, such as allowing users to set their own tag colors, and directly saving the colors to storage, so that tags retain their colors even if the hash code algorithm changes.
-
-
-
-
Modify
NewResultAvailableEvent
such thatResultDisplay
can show a different style on error (currently it shows the same regardless of errors).Before
After
-
Hints
-
NewResultAvailableEvent
is raised byCommandBox
which also knows whether the result is a success or failure, and is caught byResultDisplay
which is where we want to change the style to. -
Refer to
CommandBox
for an example on how to display an error.
-
-
Solution
-
Modify
NewResultAvailableEvent
's constructor so that users of the event can indicate whether an error has occurred. -
Modify
ResultDisplay#handleNewResultAvailableEvent(NewResultAvailableEvent)
to react to this event appropriately. -
You can write two different kinds of tests to ensure that the functionality works:
-
The unit tests for
ResultDisplay
can be modified to include verification of the color. -
The system tests
AddressBookSystemTest#assertCommandBoxShowsDefaultStyle() and AddressBookSystemTest#assertCommandBoxShowsErrorStyle()
to include verification forResultDisplay
as well.
-
-
See this PR for the full solution.
-
Do read the commits one at a time if you feel overwhelmed.
-
-
-
-
Modify the
StatusBarFooter
to show the total number of people in the address book.Before
After
-
Hints
-
StatusBarFooter.fxml
will need a newStatusBar
. Be sure to set theGridPane.columnIndex
properly for eachStatusBar
to avoid misalignment! -
StatusBarFooter
needs to initialize the status bar on application start, and to update it accordingly whenever the address book is updated.
-
-
Solution
-
Modify the constructor of
StatusBarFooter
to take in the number of persons when the application just started. -
Use
StatusBarFooter#handleAddressBookChangedEvent(AddressBookChangedEvent)
to update the number of persons whenever there are new changes to the addressbook. -
For tests, modify
StatusBarFooterHandle
by adding a state-saving functionality for the total number of people status, just like what we did for save location and sync status. -
For system tests, modify
AddressBookSystemTest
to also verify the new total number of persons status bar. -
See this PR for the full solution.
-
-
Scenario: You are in charge of storage
. For your next project milestone, your team plans to implement a new feature of saving the address book to the cloud. However, the current implementation of the application constantly saves the address book after the execution of each command, which is not ideal if the user is working on limited internet connection. Your team decided that the application should instead save the changes to a temporary local backup file first, and only upload to the cloud after the user closes the application. Your job is to implement a backup API for the address book storage.
💡
|
Do take a look at Section 2.5, “Storage component” before attempting to modify the Storage component.
|
-
Add a new method
backupAddressBook(ReadOnlyAddressBook)
, so that the address book can be saved in a fixed temporary location.-
Hint
-
Add the API method in
AddressBookStorage
interface. -
Implement the logic in
StorageManager
andXmlAddressBookStorage
class.
-
-
Solution
-
See this PR for the full solution.
-
-
By creating this command, you will get a chance to learn how to implement a feature end-to-end, touching all major components of the app.
Scenario: You are a software maintainer for addressbook
, as the former developer team has moved on to new projects. The current users of your application have a list of new feature requests that they hope the software will eventually have. The most popular request is to allow adding additional comments/notes about a particular contact, by providing a flexible remark
field for each contact, rather than relying on tags alone. After designing the specification for the remark
command, you are convinced that this feature is worth implementing. Your job is to implement the remark
command.
Edits the remark for a person specified in the INDEX
.
Format: remark INDEX r/[REMARK]
Examples:
-
remark 1 r/Likes to drink coffee.
Edits the remark for the first person toLikes to drink coffee.
-
remark 1 r/
Removes the remark for the first person.
Let’s start by teaching the application how to parse a remark
command. We will add the logic of remark
later.
Main:
-
Add a
RemarkCommand
that extendsUndoableCommand
. Upon execution, it should just throw anException
. -
Modify
AddressBookParser
to accept aRemarkCommand
.
Tests:
-
Add
RemarkCommandTest
that tests thatexecuteUndoableCommand()
throws an Exception. -
Add new test method to
AddressBookParserTest
, which tests that typing "remark" returns an instance ofRemarkCommand
.
Let’s teach the application to parse arguments that our remark
command will accept. E.g. 1 r/Likes to drink coffee.
Main:
-
Modify
RemarkCommand
to take in anIndex
andString
and print those two parameters as the error message. -
Add
RemarkCommandParser
that knows how to parse two arguments, one index and one with prefix 'r/'. -
Modify
AddressBookParser
to use the newly implementedRemarkCommandParser
.
Tests:
-
Modify
RemarkCommandTest
to test theRemarkCommand#equals()
method. -
Add
RemarkCommandParserTest
that tests different boundary values forRemarkCommandParser
. -
Modify
AddressBookParserTest
to test that the correct command is generated according to the user input.
Let’s add a placeholder on all our PersonCard
s to display a remark for each person later.
Main:
-
Add a
Label
with any random text insidePersonListCard.fxml
. -
Add FXML annotation in
PersonCard
to tie the variable to the actual label.
Tests:
-
Modify
PersonCardHandle
so that future tests can read the contents of the remark label.
We have to properly encapsulate the remark in our Person
class. Instead of just using a String
, let’s follow the conventional class structure that the codebase already uses by adding a Remark
class.
Main:
-
Add
Remark
to model component (you can copy fromAddress
, remove the regex and change the names accordingly). -
Modify
RemarkCommand
to now take in aRemark
instead of aString
.
Tests:
-
Add test for
Remark
, to test theRemark#equals()
method.
Now we have the Remark
class, we need to actually use it inside Person
.
Main:
-
Add
getRemark()
inPerson
. -
You may assume that the user will not be able to use the
add
andedit
commands to modify the remarks field (i.e. the person will be created without a remark). -
Modify
SampleDataUtil
to add remarks for the sample data (delete youraddressBook.xml
so that the application will load the sample data when you launch it.)
We now have Remark
s for Person
s, but they will be gone when we exit the application. Let’s modify XmlAdaptedPerson
to include a Remark
field so that it will be saved.
Main:
-
Add a new Xml field for
Remark
.
Tests:
-
Fix
invalidAndValidPersonAddressBook.xml
,typicalPersonsAddressBook.xml
,validAddressBook.xml
etc., such that the XML tests will not fail due to a missing<remark>
element.
Since Person
can now have a Remark
, we should add a helper method to PersonBuilder
, so that users are able to create remarks when building a Person
.
Tests:
-
Add a new method
withRemark()
forPersonBuilder
. This method will create a newRemark
for the person that it is currently building. -
Try and use the method on any sample
Person
inTypicalPersons
.
Our remark label in PersonCard
is still a placeholder. Let’s bring it to life by binding it with the actual remark
field.
Main:
-
Modify
PersonCard
's constructor to bind theRemark
field to thePerson
's remark.
Tests:
-
Modify
GuiTestAssert#assertCardDisplaysPerson(…)
so that it will compare the now-functioning remark label.
We now have everything set up… but we still can’t modify the remarks. Let’s finish it up by adding in actual logic for our remark
command.
Main:
-
Replace the logic in
RemarkCommand#execute()
(that currently just throws anException
), with the actual logic to modify the remarks of a person.
Tests:
-
Update
RemarkCommandTest
to test that theexecute()
logic works.
See this PR for the step-by-step solution.
Target user profile:
-
Salesperson targeting clients from multiple countries.
-
has a need to manage a significant number of clients
-
prefer desktop apps over other types
-
prefers typing over mouse input
-
is reasonably comfortable using CLI apps
Value proposition: A client management application that includes contact management and calendar, and note-taking and supports multiple time-zones
-
Major: A calendar or appointment scheduling feature that allows the salesperson to record down when he has appointments with his clients and to see at a glance his future appointments for the days/month ahead.
-
Minor: An archival feature for clients that the salesperson is no longer in contact with so that they do not clutter up the interface as the salesperson has to manage a lot of clients.
-
Minor: A switch theme command to switch between dark and light themes.
-
Minor: Command alias feature so that user does not have to type long commands.
-
Minor: A loading screen for emails so that the app does not become unresponsive
-
Major: An email feature comprised of an email inbox panel and the ability to compose, reply and forward emails.
-
Minor: A time zone feature which allows the sales person to add the timezone details of their clients.
-
Minor: An enhancement that changes incorrect commands to red.
-
Major: A login/logout & reset password function that allows the user to verify his/her identity when he/she starts using this APP to protect his/her privacy
-
Minor: A sort command that can sort in alphabetical order.
-
Minor: A remove tag command that can remove tags from all the people in the address book.
-
Minor: A comment feature which allows the sales person to add the notes of their clients.
-
Minor: A total person at status bar to show the total number of persons in the address book.
-
Minor: A export command that can export all persons in the address book to a csv file.
Priorities: High (must have) - * * *
, Medium (nice to have) - * *
, Low (unlikely to have) - *
Priority | As a … | I want to … | So that I can… |
---|---|---|---|
|
new user |
see usage instructions |
refer to instructions when I forget how to use the App |
|
user |
Login/logout to my Addressbook to modify my contacts and appointments |
protect my data |
|
user |
schedule meetings with my clients |
remember when I am supposed to meet them |
|
user |
conveniently send emails to clients |
increase efficiency and save time |
|
user |
conveniently see my email inbox |
know when my clients are contacting me |
|
user |
tag clients with important info like the products they are interested in |
so that I can list and group together related clients quickly. |
|
user |
log notes specific to each client |
so that I can recall the information when I need it |
|
user |
add a new person |
|
|
user |
delete a person |
remove entries that I no longer need |
|
user |
find a person by name |
locate details of persons without having to go through the entire list |
|
user |
set the timezone for each contact |
meet or call them at an appropriate time |
|
user |
archive certain contacts |
useless or expired contacts won’t clutter up the program but I can still find them when I need to |
|
user |
hide private contact details by default |
minimize chance of someone else seeing them by accident |
|
user |
delete a certain tag for all persons |
remove certain tags if the relationship is not there anymore |
|
user |
export my contacts to a file |
export the data to somewhere else if I need it |
|
user with many persons in the address book |
sort persons by name |
locate a person easily |
{More to be added}
(For all use cases below, the System is the AddressBook
and the Actor is the user
, unless specified otherwise)
MSS
-
User searches for a specific client
-
AddressBook shows a list of users matching query
-
User puts the contact into the desired category (a user can have many).
-
System updates contact to reflect new category.
Use case ends.
Extensions
-
2a. The list is empty.
Use case ends.
-
2a1. The contact is not found.
Use case resumes at step 1.
-
3a. The category does not exist.
User creates a new category. Use case resumes at step 3. ** 3a1. AddressBook shows an error message.
+ Use case resumes at step 2.
MSS
-
System puts users in the inactive category if contact had no activity for a specified period of time.
-
User filters contacts to show those in the inactive category.
-
System displays users which are in the inactive category.
-
User selects which contacts to archive.
-
System moves archived contacts into the archived category.
Use case ends.
Extensions
-
3a. No users are in the inactive category.
Use case ends.
-
4a. The user does not select any contacts.
Use case ends.
MSS
-
Sell IT shows the user a list of clients.
-
User clicks the email of the client they want to contact.
-
Sell IT displays the email compose pop up box.
-
User types their email contents and pushes the send button.
-
Sell IT attempts to send their email and displays a success or failure message.
-
User closes the pop up by pressing the ESCAPE key or the return button.
Extensions
-
4a. The user clicks cancel.
Use case ends.
-
Should work on any mainstream OS as long as it has Java
1.8.0_60
or higher installed. -
Should work with a large number of, which is more than 1000, contacts.
-
Should respond quickly after any action, which is less than 2 seconds.
-
Should store its data in plain text so that data can be manually accessed if required.
-
A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.
-
All actions should be performable using only the keyboard.
{More to be added}
- Mainstream OS
-
Windows, Linux, Unix, OS-X
- Private contact detail
-
A contact detail that is not meant to be shared with others
- Archive
-
The list of contacts that are no longer in use
- Client
-
A potential customer, someone the user is in contact with for the purposes of business
- Notes
-
Some plain text information associated with a contact that the user wants to remember
Given below are instructions to test the app manually.
ℹ️
|
These instructions only provide a starting point for testers to work on; testers are expected to do more exploratory testing. |
-
Initial launch
-
Download the jar file and copy into an empty folder
-
Double-click the jar file
Expected: Shows the GUI with a set of sample contacts. The window size may not be optimum.
-
-
Saving window preferences
-
Resize the window to an optimum size. Move the window to a different location. Close the window.
-
Re-launch the app by double-clicking the jar file.
Expected: The most recent window size and location is retained.
-
{ more test cases … }
-
Deleting a person while all persons are listed
-
Prerequisites: List all persons using the
list
command. Multiple persons in the list. -
Test case:
delete 1
Expected: First contact is deleted from the list. Details of the deleted contact shown in the status message. Timestamp in the status bar is updated. -
Test case:
delete 0
Expected: No person is deleted. Error details shown in the status message. Status bar remains the same. -
Other incorrect delete commands to try:
delete
,delete x
(where x is larger than the list size) {give more}
Expected: Similar to previous.
-
{ more test cases … }
-
Adding an appointment
-
Test case: Run
addappointment
with valid parameters.
Expected: Appointment added. -
Test case: Run
addappointment
with invalid parameters.
Expected: Error message displayed showing the required format.
-
-
Deleting an appointment
-
Test case: Run
deleteappointment 1
Expected: The first appointment is deleted -
Test case: Run
deleteappointment InvalidIndex
Expected: Error message displayed.
-
-
Editing an appointment
-
Test case: Run
editappointment
with valid parameters.
Expected: Appointment edited. -
Test case: Run
editappointment
without any edit information.
Expected: Error message displayed.
-
-
Archiving a client
-
Test case: Run
archive INDEX
where INDEX is a valid person index.
Expected: Person disappears from list.
-
-
Listing all clients including archived
-
Prerequisite: Archive some client as in the archive client test.
-
Test case: Run
listall
.
Expected: Archived person is listed with red font and strikethrough.
-
-
Unarchiving a client
-
Prerequisite: Some person archived and listed as in List all clients test.
-
Test case: Run
unarchive INDEX
where INDEX is the index of an archived person.
Expected: Person becomes unarchived and is listed in a normal font.
-
-
Switching theme
-
Test case: Run
switch
.
Expected: Theme is switched from dark to light and vice-versa. -
Test case: Close and open the application.
Expected: Theme is saved across restarts.
-
-
Lock the addressbook to prevent further modification on contacts or appointment
-
Test case: Run
lock
.
Expected: All the contacts and appointments are gone. And further commands are not accepted
-
-
Unlock the addressbook for further modification on contacts or appointment
-
Prerequisite: The addressbook is already locked.
-
Test case: Run
unlock PASSWORD
.
Expected: The addressbook is unlock and starts to accept more commands. Please note that the contatcs and appointments will not be shown automatically, please use list and listappointment command to see.
-
-
Change the lock password
-
Test case: Run
setPassword OLD_PASSWORD NEW_PASSWORD
.
Expected: The password is changed.
-
-
Listing all appointments
-
Test case: Run
listappointment
.
Expected: All the appointments are listed.
-
-
Sorting all contacts
-
Test case: Run
sort
.
Expected: All the contacts in addressbook are sorted based on alphabetical order.
-
-
Removing tags from all contatcs
-
Prerequisite: There are already some tags in the addressbook.
-
Test case: Run
removetag TAGNAME
.
Expected: The specified tag is removed from all the contacts in addressbook.
-
-
Export all contatcs
-
Prerequisite: There are already some contactss in the addressbook.
-
Test case: Run
export
.
Expected: All the contacts in the addressbook are exported to a csv file.
-
-
Add comments to contacts
-
Prerequisite: There are already some contacts in the addressbook.
-
Test case: Run
add n/David p/98765432 e/[email protected] a/311, Clementi Ave 2, #02-25 tz/PST c/interested in football t/friends t/owesMoney
.
Expected: A contact is created with comment interested in football. -
Test case: Run
edit 1 c/interested in basketball
.
Expected: The first contact’s comment is modified to interested in basketball.
-
-
Time zone abbreviations unknown to Java are rejected
-
Prerequisite: There is at least one contact in Sell IT
-
Test case: Run
add n/David p/98765432 e/[email protected] a/311, Clementi Ave 2, #02-25 tz/PST c/interested in football t/friends
.
Expected: A contact is created with the time zone PST is created. -
Test case: Run
edit 1 tz/PST
.+ Expected: The client with index 1 has their time zone changed to PST -
Test case: Run
add n/David p/98765432 e/[email protected] a/311, Clementi Ave 2, #02-25 tz/ c/interested in football t/friends
.
Expected: Error message:Time zones should be have the standard time zone abbreviations, and should not be blank
. -
Test case: Run
edit 1 tz/P$T
.
Expected: Error message:Time zones should be have the standard time zone abbreviations, and should not be blank
.
-
-
Send an email to a client
-
Prerequisite: There is at least one email in Sell IT
-
Test case: Click a client’s email in the person panel and enter a subject and the email message body and click the send button.
Expected: Email sent successfully window. -
Test case: Click the new email button after clicking an email in the inbox and do not enter any recipients and click the send button.
Expected: Could not send email due to an error window. -
Test case: Click the new email button after clicking an email in the inbox and enter
abcde
as the recipient and click the send button.
Expected: Could not send email due to an error window. -
Test case: Click the new email button after clicking an email in the inbox and enter
@gmail.com
as the recipient and click the send button.
Expected: Could not send email due to an error window.
-
-
Reply to an email an email received from a client
-
Prerequisite: There is at least one email in Sell IT.
-
Test case: Click the reply button after clicking an email in the inbox and type some text in the email body.
Expected: Email sent successfully window. -
Test case: Click the reply button after clicking an email in the inbox and add an invalid recipient such as
asdf
.
Expected: Could not send email due to an error window.
-
-
Forward an email received from a client
-
Prerequisite: There is at least one contact or email in Sell IT
-
Test case: Click the forward button after clicking an email in the inbox and enter a valid email and click send
Expected: Email sent successfully window. -
Test case: Click the forward button after clicking an email in the inbox and enter an invalid recipient such as
asdf
.
Expected: Could not send email due to an error window.
-
-
Load all client emails.
-
Prerequisite: There is at least one email message received in Sell IT
-
Test case: See which emails are loaded onto the email panel. On a browser, log onto the gmail with the email "[email protected]" and password "gloriacs2103" and verify they are the same.
Expected: Email inbox should be the same as what is shown on gmail.
-
-
Receive an email from a client.
-
Prerequisite: None
-
Test case: From an email you have access to, send an plain text email to "[email protected]".
Expected: Email appears on the email panel within 30 seconds and the full view is opened in a pop up when clicked.
-