Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OboTerm.GetChildOntologyAnnotations does not return all children #8

Open
omaus opened this issue Jul 27, 2023 · 2 comments
Open
Assignees
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@omaus
Copy link
Member

omaus commented Jul 27, 2023

Try this:

let testTerms = [
    OboTerm.Create("test:000", Name = "test0")
    OboTerm.Create("test:001", Name = "test1a", IsA = ["test:000"])
    OboTerm.Create("test:002", Name = "test2", IsA = ["test:001"])
    OboTerm.Create("test:003", Name = "test1b", IsA = ["test:000"])
]

let testOntology = OboOntology.create testTerms []

testOntology.GetChildOntologyAnnotations(testTerms.Head.Id)

(Looks like this in a tree diagram:)

     test0
    /     \
test1a    test1b
   |
 test2

It should return "test1a", "test2", and "test1b" but the last one is missing.

If used with a first depth, it works:

testOntology.GetChildOntologyAnnotations(testTerms.Head.Id, Depth = 1)

If used with depth one level deeper, it again fails:

testOntology.GetChildOntologyAnnotations(testTerms.Head.Id, Depth = 2)

Prolly cause the algorithm goes as deep as possible and stops there. It is not capable of going back, so to speak.

@omaus omaus assigned omaus and HLWeil and unassigned omaus Jul 27, 2023
@omaus
Copy link
Member Author

omaus commented Jul 28, 2023

@HLWeil Might be more interesting for you than for me since ISA.NET might use this functionality. 😬

@HLWeil
Copy link
Member

HLWeil commented Jul 28, 2023

Yeah this is important for value querying. QueryModel in ISADotNet but not yet implemented in ARCtrl. Will get back to this Issue when I start working on that.

@omaus omaus moved this to Backlog in ARCStack Jun 5, 2024
@omaus omaus added the Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
None yet
Development

No branches or pull requests

2 participants