Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular scss and make more use of bootstrap #16

Open
lamcw opened this issue Jun 1, 2019 · 0 comments
Open

Modular scss and make more use of bootstrap #16

lamcw opened this issue Jun 1, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lamcw
Copy link
Contributor

lamcw commented Jun 1, 2019

  1. We should make use of sass and separate style.scss into several scss modules.
  2. Use bootstrap class rules instead of using our own grid system.
    E.g., replacing,
.navbar {
  box-shadow: 0px 5px 5px 2px rgba(0, 0, 0, 0.2);
}
<nav class="navbar navbar-expand-lg navbar-dark">
  <!-- other stuff here -->
</nav>

with

<nav class="navbar navbar-expand-lg navbar-dark shadow">
  <!-- other stuff here -->
</nav>
@lamcw lamcw added the enhancement New feature or request label Jun 1, 2019
@lamcw lamcw self-assigned this Jun 3, 2019
@lamcw lamcw changed the title Modular scss Modular scss and make more use of boostrap Jun 4, 2019
@lamcw lamcw changed the title Modular scss and make more use of boostrap Modular scss and make more use of bootstrap Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant