Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrographs differ when running a small part of a larger model #20

Open
1 task
BernardoTeufel opened this issue Dec 5, 2023 · 6 comments
Open
1 task
Labels
bug Something isn't working

Comments

@BernardoTeufel
Copy link

Setup Information

  • Raven version: 3.6
  • Operating System: Ubuntu 20.04

Description

Ran two similar routing-only Raven simulations forced by gridded runoff. One for the entire Mackenzie basin, and the second upstream of the outlet of Great Bear Lake.

There are three gauges in the shared domain. For the gauge without any lakes in the upstream area (sub2024874), the results look almost as expected (no difference whatsoever between both hydrographs), except for the last timestep:

image

For the other two gauges (which have upstream lakes), simulations differ significantly:

image
image

Steps To Reproduce

No response

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to address this bug.
@BernardoTeufel BernardoTeufel added the bug Something isn't working label Dec 5, 2023
@analytophile
Copy link
Contributor

Hi Bernardo - can you generate and check the ForcingFunctions.csv file to ensure these are identical, then also examine the differences between ReservoirStages.csv and ReservoirMassBalance.csv files so we can pinpoint the source of the deviation. Its hard with a Mackenzie-sized model to nail this down to the actual problem.

@BernardoTeufel
Copy link
Author

Hi James, wouldn't ForcingFunctions.csv be expected to be different? (Mackenzie-average vs Great Bear-average)

ReservoirMassBalance.csv narrowed down the problem. Precip is always same for both simulations, inflows are also equal when there are no upstream lakes, but outflows (and stages, and volumes) are always different. This hints at evaporation as the culprit, but it is incorrectly reported as zero in the file (see #21)

Setting evaporation to zero (desirable for my case) gets rid of the differences:
(v3.7) :OW_Evaporation PET_NONE
(v3.6) :OW_Evaporation PET_CONSTANT (with the hardcoded constant changed to zero)

@analytophile
Copy link
Contributor

I believe this was fixed in revision fb00c23 - it was an issue that was arising when land use parameter LAKE_PET_CORR was not specified in the .rvp file. Could you specify this parameter as 1.0 in v3.7 with a PET method other than PET_NONE and verify whether the issue is reconciled?

@BernardoTeufel
Copy link
Author

I've used the latest version from this repository, and I've set LAKE_PET_CORR to 1.0 in the .rvp file for both simulations. I did not specify any PET method, which defaults to PET_HARGREAVES_1985.

The issue still occurs. I looked into ReservoirMassBalance.csv and confirmed that the issue is (still) related to evaporation (black line is Great Bear simulation, red line is entire Mackenzie, for the same reservoir in both simulations):

image

I looked into the PET_HARGREAVES_1985 algorithm, which depends only on temperature (F->temp_daily_max, F->temp_daily_min and F->temp_daily_ave) and radiation (F->ET_radia). Radiation is identical for both simulations, but temperature can differ by over 10 degC between both simulations (first 5 days are identical, then differences start to grow):

image

Plot is for difference in F->temp_daily_ave, and plots for max and min look similar.

@analytophile
Copy link
Contributor

how are you supplying temperature forcings to the model? i.e., is this gage-based or gridded temperature data? I assume that these are temperatures for the reservoir HRU, correct? And that supplied temperature datasets are identical?

@BernardoTeufel
Copy link
Author

I'm supplying gridded temperature data (hourly data), and both simulations are reading the same file. The temperatures I plotted are indeed for the reservoir HRU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants