From a187ec4832833c8e67b107136b295b0635dc7558 Mon Sep 17 00:00:00 2001
From: Zachary Trabookis <ztraboo@clemson.edu>
Date: Tue, 10 Sep 2024 11:50:02 -0400
Subject: [PATCH] feat(config): Github actions artifact v4 upgrade.

V1 and V2 of Github artifact actions was deprecated. Upgraded to V4 latest version.

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
---
 .github/actions/unit-tests/action.yml | 3 ++-
 .github/workflows/js-tests.yml        | 3 ++-
 .github/workflows/quality-checks.yml  | 3 ++-
 .github/workflows/unit-tests.yml      | 5 +++--
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/.github/actions/unit-tests/action.yml b/.github/actions/unit-tests/action.yml
index 71ca72a7da11..06f25a06f97e 100644
--- a/.github/actions/unit-tests/action.yml
+++ b/.github/actions/unit-tests/action.yml
@@ -27,8 +27,9 @@ runs:
 
     - name: save pytest warnings json file
       if: success()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: pytest-warnings-json
         path: |
           test_root/log/pytest_warnings*.json
+        overwrite: true
diff --git a/.github/workflows/js-tests.yml b/.github/workflows/js-tests.yml
index 4cf9b645564e..d5a04a58ee00 100644
--- a/.github/workflows/js-tests.yml
+++ b/.github/workflows/js-tests.yml
@@ -73,7 +73,7 @@ jobs:
         xvfb-run --auto-servernum ./scripts/all-tests.sh
 
     - name: Save Job Artifacts
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: Build-Artifacts
         path: |
@@ -81,3 +81,4 @@ jobs:
           test_root/log/*.png
           test_root/log/*.log
           **/TEST-*.xml
+        overwrite: true
diff --git a/.github/workflows/quality-checks.yml b/.github/workflows/quality-checks.yml
index 5ee54e43a709..48c90fabd0e8 100644
--- a/.github/workflows/quality-checks.yml
+++ b/.github/workflows/quality-checks.yml
@@ -70,10 +70,11 @@ jobs:
         ./scripts/all-tests.sh
 
     - name: Save Job Artifacts
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: Build-Artifacts
         path: |
           **/reports/**/*
           test_root/log/**/*.log
           *.log
+        overwrite: true
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
index 58a96455cc97..1b0cb42fdbb4 100644
--- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -77,7 +77,7 @@ jobs:
         run: sudo chown runner:runner -R .*
       - uses: actions/checkout@v2
       - name: collect pytest warnings files
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
         with:
           name: pytest-warnings-json
           path: test_root/log
@@ -91,10 +91,11 @@ jobs:
 
       - name: save warning report
         if: success()
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: pytest-warning-report-html
           path: |
             reports/pytest_warnings/warning_report_all.html
+          overwrite: true