Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hwctrl motor topics #42

Open
edf42001 opened this issue Nov 13, 2020 · 7 comments · May be fixed by #74
Open

Refactor hwctrl motor topics #42

edf42001 opened this issue Nov 13, 2020 · 7 comments · May be fixed by #74
Assignees
@BBScholar

Comments

@edf42001
Copy link
Collaborator

I heard this was being done by someone on the hardware team
@JHorwitz1011
Copy link

JHorwitz1011 commented Nov 17, 2020 •
edited
Loading

yeah thats me - sorry really busy I'll be getting to it over winter break.

@edf42001
Copy link
Collaborator Author

edf42001 commented Nov 17, 2020 •
edited
Loading

Neato

Make sure your work doesn't conflict with all of Ben's refactoring he's doing

@edf42001
Copy link
Collaborator Author

edf42001 commented Feb 6, 2021

Has this been completed on the hwctrl side?

I just saw in the document that there are now /glenn_base/port_motor_cmd and such so that needs to be fixed on the sending side (i.e. python side)

@BBScholar
Copy link
Member

I dont think it has. Ill have to make some adjustments.

@BBScholar
Copy link
Member

or someone else can if they want

@JHorwitz1011
Copy link

I think this was supposed to be me but I don't really feel too confident or comfortable with the repo to handle it. Ben, if you could pick it up for me I'd really appreciate it.

@BBScholar
Copy link
Member

Sure thing. I need to work on the motor controller drivers anyways.

@BBScholar BBScholar assigned BBScholar and unassigned JHorwitz1011 Feb 12, 2021
@BBScholar BBScholar linked a pull request Feb 12, 2021 that will close this issue
Motor topic refactor #74
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BBScholar BBScholar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Motor topic refactor CWRUbotix/NASA-RMC-2020
3 participants
@edf42001 @BBScholar @JHorwitz1011