Motor topic refactor #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to update the yaml with the correct topics. Do not merge yet. |
|
Ready for review @AdamC19 |
|
To confirm: we are using individual topics for left and right wheel motor values? I can change that on the python side on this branch for the merge if you want |
|
Yes, we are using separate topics for now. When I have a bit of free time I can try to make a combined topic thing, but not for now. |
|
And yes, go ahead and change the python code. Much appreciated! |
|
Python code has been changed |
|
Hey weren't we going to merge this? |
|
@edf42001 Yeah, waiting on Adam's review. He said he'll get to it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.