Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View goal / line chart flow: things that should be clearer #286

Open
emilyb7 opened this issue Apr 26, 2017 · 2 comments
Open

View goal / line chart flow: things that should be clearer #286

emilyb7 opened this issue Apr 26, 2017 · 2 comments
Labels
awaiting-review design
Milestone
Final fixes

Comments

@emilyb7
Copy link
Collaborator

emilyb7 commented Apr 26, 2017

  • Not clear that I can click on blue title above line chart preview to see detailed version
  • Not clear that I can click on the nodes in the line chart to see details of rating
  • Not clear that I can scroll horizontally across the line chart!
  • Not clear which node on line chart is currently selected...
@emilyb7 emilyb7 added this to the Final fixes milestone Apr 26, 2017
@emilyb7
Copy link
Collaborator Author

emilyb7 commented Apr 27, 2017

feedback from noga:

  • animate the arrow on the blue title
  • select the latest rating by default
  • increase size of selected icon if possible
  • Add an arrow above the line chart showing that we can scroll (only if scrolling possible)

emilyb7 added a commit that referenced this issue Apr 27, 2017
@emilyb7
adds arrow animation above line chart
45e9571 
whole line chart is clickable and links to line-chart-detail view
related ##286
emilyb7 added a commit that referenced this issue Apr 27, 2017
@emilyb7
tidy up styles for arrow animation, related #286
2a1db39
emilyb7 added a commit that referenced this issue Apr 27, 2017
@emilyb7
latest rating selected by default when going to line-chart-detail view
e184602 
related #286
emilyb7 added a commit that referenced this issue Apr 27, 2017
@emilyb7
fixes position of arrow for different screen sizes, related #286
bddb37b
emilyb7 added a commit that referenced this issue Apr 27, 2017
@emilyb7
line chart scrolls into view on page load
477105a 
delays appearance of div with rating detail
related #286
emilyb7 added a commit that referenced this issue Apr 27, 2017
@emilyb7
more line chart animation things, a bit broken still... related #286
9ac0335
emilyb7 added a commit that referenced this issue Apr 27, 2017
@emilyb7
tidies up code, related to ##286
ed63505
This was referenced May 1, 2017
Closed
Merged
@emilyb7
Copy link
Collaborator Author

emilyb7 commented May 1, 2017

won't do increasing the size of the icon on click

the only way i can figure out how to do this, is to redraw the chart on every state change. and it's causing too many errors at the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting-review design
Projects
None yet
Milestone
Final fixes
Development

No branches or pull requests
1 participant
@emilyb7