Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device flow authorization endpoint #884

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bacek
Copy link

@bacek bacek commented Nov 6, 2024

Device authorization endpoint is device_authorization_endpoint as per https://www.rfc-editor.org/rfc/rfc8628.html#section-4

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

Device authorization endpoint is `device_authorization_endpoint` as per https://www.rfc-editor.org/rfc/rfc8628.html#section-4
@tpazderka tpazderka self-requested a review November 11, 2024 07:46
@@ -94,7 +94,7 @@ def authorization_request(self, scope=""):
req["scope"] = scope

http_response = self.host.http_request(
self.host.provider_info["device_endpoint"], "POST", req.to_urlencoded()
self.host.provider_info["device_authorization_endpoint"], "POST", req.to_urlencoded()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the formatting as suggested by the formater?

Running black src/ tests/ should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants