Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 ping only blindly marks host Down #261

Closed
dschultzca opened this issue Apr 29, 2022 · 1 comment
Closed

IPv6 ping only blindly marks host Down #261

dschultzca opened this issue Apr 29, 2022 · 1 comment

Comments

@dschultzca
Copy link

dschultzca commented Apr 29, 2022

In all repo branch versions of ping.c code, IPv6 hosts as marked down in the } else if (host->availability_method == AVAIL_PING) { block.

		if (!strstr(host->hostname, "localhost")) {
			if (get_address_type(host) == 1) {
				if (host->ping_method == PING_ICMP) {
					ping_result = ping_icmp(host, ping);
				} else if (host->ping_method == PING_UDP) {
					ping_result = ping_udp(host, ping);
				} else if (host->ping_method == PING_TCP) {
					ping_result = ping_tcp(host, ping);
				}
			} else if (host->availability_method == AVAIL_PING) {
				snprintf(ping->ping_status, 50, "0.000");
				snprintf(ping->ping_response, SMALL_BUFSIZE, "PING: Device is Unknown or is IPV6.  Please use the SNMP ping options only.");
				return HOST_DOWN;
			}

It is expected that IPv6 hosts are treated as well as IPv4 hosts and provide a true ping result on both Linux and Windows OS.

@TheWitness TheWitness added this to the v1.2.22 milestone May 4, 2022
@TheWitness TheWitness modified the milestones: v1.2.22, v1.2.23 Aug 25, 2022
@TheWitness TheWitness modified the milestones: v1.2.23, v1.2.24 Nov 20, 2022
@TheWitness TheWitness modified the milestones: v1.2.24, v1.3.0 Dec 17, 2022
@TheWitness
Copy link
Member

Duplicate of #127. I'm closing this one. I think until we get a contribution of PING6, we will have to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants