Fix unexpected edges

[Peque]

Sometimes edges are displayed in cylinders. See the Bulebule mounting design.

The little holes have vertical edges (i.e.: the hole is not a smooth surface).

Currently we are avoiding edges when the degrees between 2 surfaces is higher than 5 with:

var edges = new THREE.EdgesGeometry( geometry, 5 );

But that sounds arbitrary.

• Is there a way to avoid edges in cylinders, which are supposed to be smooth surfaces independently of their diameter?
• Is it something we cannot fix and the only workaround is to increase the edges-degrees above 5 or increase the precision in the generated TJS file?
• Would using another intermediate format help?

[izhuravlev]

Hey @Peque,
I will be happy to have a look an try to figure out the solution as soon as I can!

[Peque]

@izhuravlev Great! 💪

You can also have a look at #10. Another issue related to edges display.

If you have any questions just ask. 😉

[izhuravlev]

Hi @Peque,
I am looking forward to work on this bug during this weekend - already cloned the project and set up my environment - could you please tell me how can I test my work - for example, provide me with a testing file or explain how to create one?
It will be awesome if you can also share with me some more details on how can I proceed with this one.
Thank You!

[Peque]

@izhuravlev Sure, you can use this one (it is actually the one on the picture).

Apart from that, and what is already written in this issue, I cannot give you further advise. 😊

[izhuravlev]

Thank you @Peque, I will continue working on this one.

[Peque]

This should be fixed now by 6e9c73a.