Added a "ModifiesAddedAssets" variable to IModCustomHandler #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows custom handlers to apply (and therefore merge) duplicated assets. The use case being in SWBF2 it is possible to create new subworlds which need mergable network registries in order for players syncronise correctly in MP servers. This functionality is completely disabled for all of the base Frosty plugins (besides the Gameplay Merger which I have specifically set it up for) so you don't need to worry about it breaking those plugins. Feel free to find a flaw in my code, this implementation is as simple as I could make it and I have tested it in both FMM and FE.
|
I dont think changing an interface which is implemented by plugins is a good idea |
|
also this is missing a lot of stuff for it to properly work with how handlers should be implemented, so if any other thirdparty plugin would want to merge added assets all the assetmanager function will not work properly |
|
like even in the modexecutor its only setup for ebx not res or chunks, so yeah i dont think this will work for 1.0.6.3, i dont want to add any more hacky stuff into it, especially since this will only have a very limited use |
|
Well then you should remove the gameplay merger from FMM because that’s an even bigger hack than this and will be designed around this in future updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows custom handlers to apply (and therefore merge) duplicated assets. The use case being in SWBF2 it is possible to create new subworlds which need mergable network registries in order for players synchronise correctly in MP servers. This functionality is completely disabled for all of the base Frosty plugins (besides the Gameplay Merger which I have specifically set it up for) so you don't need to worry about it breaking those plugins. Feel free to find a flaw in my code, this implementation is as simple as I could make it and I have tested it in both FMM and FE.