Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModSupport] Improve performance for applying mods #342

Draft
wants to merge 5 commits into
base: 1.0.6.4
Choose a base branch
from

Conversation

shoushou1106
Copy link
Contributor

  • Change ThreadPool to Parallel.ForEach
  • Add MaxDegreeOfParallelism to config

ThreadPool will cause lagging because computer are not powerful enough to support that many threads
But this may require more test results, here are the results on my computer

Computer with SSD

Test game: GW2

ThreadPool(Original): 33s (very lag)
Parallel.ForEach(2 Thread): 32s (no lag)
Parallel.ForEach(1 Thread): 32s (slight lag)
Parallel.ForEach(4 Thread): 40s (very lag)

I will test on computer with HDD drive later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant