Revert detection of Overwolf Overlay

They claim this has since been fixed. We will re-examine in the future if we see additional reports. This reverts commit e7ea6f7.
CaffeineMC · Nov 12, 2024 · 4aa61cc · 4aa61cc
1 parent 5dbc892
commit 4aa61cc
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 25 deletions.
diff --git a/...rc/workarounds/java/net/caffeinemc/mods/sodium/client/compatibility/checks/BugChecks.java b/...rc/workarounds/java/net/caffeinemc/mods/sodium/client/compatibility/checks/BugChecks.java
@@ -10,7 +10,6 @@ class BugChecks {
     public static final boolean ISSUE_2048 = configureCheck("issue2048", true);
     public static final boolean ISSUE_2561 = configureCheck("issue2561", true);
     public static final boolean ISSUE_2637 = configureCheck("issue2637", true);
-    public static final boolean ISSUE_2862 = configureCheck("issue2862", true);
 
     private static boolean configureCheck(String name, boolean defaultValue) {
         var propertyValue = System.getProperty(getPropertyKey(name), null);

diff --git a/...orkarounds/java/net/caffeinemc/mods/sodium/client/compatibility/checks/ModuleScanner.java b/...orkarounds/java/net/caffeinemc/mods/sodium/client/compatibility/checks/ModuleScanner.java
@@ -36,10 +36,6 @@ public class ModuleScanner {
             "GTIII-OSD64.dll",      "GTIII-OSD.dll"
     };
 
-    private static final String[] OVERWOLF_OVERLAY_MODULE_NAMES = {
-            "gep_minecraft.dll"
-    };
-
     public static void checkModules(NativeWindowHandle window) {
         List<String> modules;
 
@@ -67,13 +63,6 @@ public static void checkModules(NativeWindowHandle window) {
         if (BugChecks.ISSUE_2637 && isModuleLoaded(modules, ASUS_GPU_TWEAK_MODULE_NAMES)) {
             checkASUSGpuTweakIII(window);
         }
-
-        // OverWolf's overlay is broken and modifies the texture bindings from underneath Minecraft. Since disabling
-        // OpenGL state caching in Minecraft for every texture bind is unacceptable, and OverWolf does not provide
-        // any way to detect broken versions of their software, we block all versions.
-        if (BugChecks.ISSUE_2862 & isModuleLoaded(modules, OVERWOLF_OVERLAY_MODULE_NAMES)) {
-            checkOverwolfOverlay(window);
-        }
     }
 
     private static List<String> listModules() {
@@ -150,19 +139,6 @@ private static void checkASUSGpuTweakIII(NativeWindowHandle window) {
                 "see here for more details: https://github.com/CaffeineMC/sodium/wiki/Known-Issues#asus-gtiii-incompatible");
     }
 
-    private static void checkOverwolfOverlay(NativeWindowHandle window) {
-        MessageBox.showMessageBox(window, MessageBox.IconType.ERROR, "Sodium Renderer",
-                """
-                        The Overwolf Overlay is not compatible with Minecraft and causes graphical corruption. Please disable the in-game overlay in the Overwolf application, or uninstall the software from your computer.
-                        
-                        For more information on how to solve this problem, click the 'Help' button.""",
-                "https://github.com/CaffeineMC/sodium/wiki/Known-Issues#overwolf-overlay");
-
-        throw new RuntimeException("Overwolf Overlay is not compatible with Minecraft, " +
-                "see here for more details: https://github.com/CaffeineMC/sodium/wiki/Known-Issues#overwolf-overlay");
-
-    }
-
     private static @Nullable WindowsFileVersion findRTSSModuleVersion() {
         long module;