Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config API and Options Screen Redesign #2837

Open
wants to merge 31 commits into
base: dev
Choose a base branch
from
Open

Config API and Options Screen Redesign #2837

wants to merge 31 commits into from
+5,354 −1,651

Conversation

douira
Copy link
Collaborator

@douira douira commented Oct 24, 2024 •
edited
Loading

Also thanks to @KingContaria for writing code on which I based the forge mod config entrypoint loader. @IMS212 wrote the initial redesign of the options page.

There's a bunch of TODOs in the code that I want to address. Feel free to help me with them and I'll merge them into this PR.

The design of the page as well as the outwards facing API are open to feedback and remain subject to change until release.

fixes #2309
fixes #2831

@douira douira mentioned this pull request Oct 27, 2024
Merged
IMS212 and others added 14 commits November 1, 2024 01:37
@IMS212 @douira
New game GUI experiment
61db95c
@douira
Add WIP config api with IMS' redesign of the options page and contari…
4b68c3b 
…a's forge mod entrypoint loader code
@douira
scrollabe page list
5b18c79 
authored by @KingContaria
@douira
allow users to set their own theme colors,
94793b0 
fix some issues when text is too long
@douira
add api to add custom screens, use a color theme builder instead of a…
328d230 
… direct method
@douira
move important members of option builder subinterfaces more useful
b66afea
@douira
refactor: store dimensions in AbstractWidget
ef1df63 
Co-authored-by: contaria <[email protected]>
@douira
new: scrollable option list
b627ad3 
Co-authored-by: contaria <[email protected]>
@douira
fix: move sliders and tickboxes when sccrolling
fe9b2a6 
Co-authored-by: contaria <[email protected]>
@douira
add api method for formatting version instead of setting a new one
720ecbd
@douira
fix crash not working correctly
d5ba7d0
@douira
move layout constants into separate class,
7706825 
fix gradient behind sidebar,
change layout of buttons and options panes,
fix overlapping ui elements,
fix scissor areas,
make spacings and arrangement consistent
@douira
constrain tooltip to screen
1742e41
@douira
fix tooltip after rebase
1189d81
@douira
Copy link
Collaborator Author

douira commented Nov 3, 2024

After implementing dynamic value constraints in the slider and cycler control elements, the remaining TODOs are not necessary for the basic required features to work and it's ready for review. The requests for additions to the API were implemented.
The search bar is not yet functional, but we can simply remove that without regressing the UX and add it when it gets implemented later. @KingContaria mentioned he wanted to work on the tooltip scroller and I plan on slowly working through the other remaining non-essential TODOs, which are related to UX/UI.
One thing I can't do and should be clarified before we release, is the automatic import of vanilla options into our options screen that @IMS212 had prototyped. I don't have that code but would integrate it if provided with it.

@douira douira marked this pull request as ready for review November 3, 2024 04:16
@douira
add annotation-based entrypoint loading on neoforge, refactored how m…
a3a5b84 
…od metadata is retrieved, updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellysquid3 jellysquid3 Awaiting requested review from jellysquid3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@douira @IMS212 @haykam821 @KingContaria