Feature: Support ClickHouse data source #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlyjackfrost
commented
Jul 3, 2024
| export interface IbisBigQueryConnectionInfo { | ||
| project_id: string; | ||
| dataset_id: string; | ||
| credentials: string; // base64 encoded | ||
| } | ||
|
|
||
| export type IbisConnectionInfo = | ||
| | UrlBasedConnectionInfo | ||
| | HostBasedConnectionInfo |
There was a problem hiding this comment.
The connection info of MySQL, Postgres, MS SQL, and ClickHouse are similar and can be classified into host-based or URL-based connection info
onlyjackfrost
commented
Jul 3, 2024
| @@ -68,7 +68,7 @@ const defaultConfig = { | |||
| wrenAIEndpoint: 'http://localhost:5555', | |||
|
|
|||
| // ibis server | |||
| ibisServerEndpoint: 'http://localhost:8000', | |||
| ibisServerEndpoint: 'http://127.0.0.1:8000', | |||
There was a problem hiding this comment.
I couldn't connect to the ibis server using localhost but using 127.0.0.1 would do
wwwy3y3
approved these changes
Jul 5, 2024
onlyjackfrost
force-pushed
the
feature/clickhouse
branch
from
046b04f to
cfd6295
Compare
onlyjackfrost
added a commit
that referenced
this pull request
Jul 11, 2024
* add ClickHouse data source * remove unused interface * support clickhouse UI * update ibis base url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ClickHouse data source