Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wren-ui): Add loading state for edit metadata updates #940

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore(wren-ui): Add loading state for edit metadata updates #940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 67 additions & 54 deletions wren-ui/src/pages/modeling.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,15 @@ export default function Modeling() {
}),
);

const [updateCalculatedField] = useUpdateCalculatedFieldMutation(
getBaseOptions({
onError: null,
onCompleted: () => {
message.success('Successfully updated calculated field.');
},
}),
);
const [updateCalculatedField, { loading: calculatedFieldUpdating }] =
useUpdateCalculatedFieldMutation(
getBaseOptions({
onError: null,
onCompleted: () => {
message.success('Successfully updated calculated field.');
},
}),
);

const [deleteCalculatedField] = useDeleteCalculatedFieldMutation(
getBaseOptions({
Expand All @@ -118,14 +119,15 @@ export default function Modeling() {
}),
);

const [createModelMutation, createModelResult] = useCreateModelMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully created model.');
},
refetchQueries: refetchQueriesForModel,
}),
);
const [createModelMutation, { loading: modelCreating }] =
useCreateModelMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully created model.');
},
refetchQueries: refetchQueriesForModel,
}),
);

const [deleteModelMutation] = useDeleteModelMutation(
getBaseOptions({
Expand All @@ -136,14 +138,15 @@ export default function Modeling() {
}),
);

const [updateModelMutation, updateModelResult] = useUpdateModelMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully updated model.');
},
refetchQueries: refetchQueriesForModel,
}),
);
const [updateModelMutation, { loading: modelUpdating }] =
useUpdateModelMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully updated model.');
},
refetchQueries: refetchQueriesForModel,
}),
);

const [deleteViewMutation] = useDeleteViewMutation(
getBaseOptions({
Expand All @@ -153,21 +156,23 @@ export default function Modeling() {
}),
);

const [updateModelMetadata] = useUpdateModelMetadataMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully updated model metadata.');
},
}),
);
const [updateModelMetadata, { loading: modelMetadataUpdating }] =
useUpdateModelMetadataMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully updated model metadata.');
},
}),
);

const [createRelationshipMutation] = useCreateRelationshipMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully created relationship.');
},
}),
);
const [createRelationshipMutation, { loading: relationshipCreating }] =
useCreateRelationshipMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully created relationship.');
},
}),
);

const [deleteRelationshipMutation] = useDeleteRelationshipMutation(
getBaseOptions({
Expand All @@ -177,21 +182,23 @@ export default function Modeling() {
}),
);

const [updateRelationshipMutation] = useUpdateRelationshipMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully updated relationship.');
},
}),
);
const [updateRelationshipMutation, { loading: relationshipUpdating }] =
useUpdateRelationshipMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully updated relationship.');
},
}),
);

const [updateViewMetadata] = useUpdateViewMetadataMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully updated view metadata.');
},
}),
);
const [updateViewMetadata, { loading: viewMetadataUpdating }] =
useUpdateViewMetadataMutation(
getBaseOptions({
onCompleted: () => {
message.success('Successfully updated view metadata.');
},
}),
);

const diagramData = useMemo(() => {
if (!data) return null;
Expand Down Expand Up @@ -364,7 +371,11 @@ export default function Modeling() {
}
};

const calculatedFieldLoading = calculatedFieldCreating;
const calculatedFieldLoading =
calculatedFieldCreating || calculatedFieldUpdating;
const editMetadataLoading = modelMetadataUpdating || viewMetadataUpdating;
const modelLoading = modelCreating || modelUpdating;
const relationshipLoading = relationshipUpdating || relationshipCreating;

return (
<DeployStatusContext.Provider value={{ ...deployStatusQueryResult }}>
Expand Down Expand Up @@ -393,6 +404,7 @@ export default function Modeling() {
<EditMetadataModal
{...editMetadataModal.state}
onClose={editMetadataModal.closeModal}
loading={editMetadataLoading}
onSubmit={async ({ nodeType, data }) => {
const { modelId, viewId, ...metadata } = data;
switch (nodeType) {
Expand All @@ -419,7 +431,7 @@ export default function Modeling() {
<ModelDrawer
{...modelDrawer.state}
onClose={modelDrawer.closeDrawer}
submitting={createModelResult.loading || updateModelResult.loading}
submitting={modelLoading}
onSubmit={async ({ id, data }) => {
if (id) {
await updateModelMutation({ variables: { where: { id }, data } });
Expand All @@ -445,6 +457,7 @@ export default function Modeling() {
<RelationModal
{...relationshipModal.state}
onClose={relationshipModal.onClose}
loading={relationshipLoading}
onSubmit={async (
values: RelationFormValues & { relationId?: number },
) => {
Expand Down