Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: dispatch event according actions for easier integration with other libraries #54

Open
winston0410 opened this issue Apr 8, 2023 · 2 comments

Comments

@winston0410
Copy link

Right now this lib does not dispatch any event, which makes integrating with other libraries difficult. For example, if I am using Dialog action, it would be great if an close event will be dispatched when dialog.close is called, so that I can do something custom after that dialog is closed(For example toggle a boolean in local storage so that user will not see that dialog again)

Is that something you would consider in this library? I can help with PR but want to know your thought first

@winston0410
Copy link
Author

@CaptainCodeman Do you have any thought on this? Right now I can see Grail UI is offering an event handler, and it would be great this library of this as well, (and even better we emit the event through native API, so user can consume the event with on:custom_event where ever they want)

@CaptainCodeman
Copy link
Owner

Yes, I think some events would make sense. The main ones I can think of will be things opening / closing and selections changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants