Skip to content

Commit

Permalink
CommonDefaults: CPN OUT_BLH_MASK 1
Browse files Browse the repository at this point in the history
A value of 3 means "query OUT1 and OUT2 for telemetry". The new APD
firmware sends telemetry always, without waiting for a query. This meant
that both OUT1 and OUT2 were showing active telemetry, despite the fact
that OUT2 is disabled in the configuration. This caused errant duplicate
esc.Status packets that toggled between an index of `motor_index` and 1.

This was causing the second ESCs telemetry to get clobbered with all the
other ESCs data in the log.
SW-259
  • Loading branch information
loki077 committed Jun 21, 2024
1 parent 73a92e7 commit f5a1066
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ OUT1_MAX 2000
OUT1_TRIM 1000
OUT1_FUNCTION 33
OUT2_FUNCTION 0
OUT_BLH_MASK 3
OUT_BLH_MASK 1
OUT_BLH_OTYPE 6
OUT_BLH_POLES 28
OUT_BLH_EXTLM 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ OUT1_MAX 2000
OUT1_TRIM 1000
OUT1_FUNCTION 34
OUT2_FUNCTION 0
OUT_BLH_MASK 3
OUT_BLH_MASK 1
OUT_BLH_OTYPE 6
OUT_BLH_POLES 28
OUT_BLH_EXTLM 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ OUT1_MAX 2000
OUT1_TRIM 1000
OUT1_FUNCTION 35
OUT2_FUNCTION 0
OUT_BLH_MASK 3
OUT_BLH_MASK 1
OUT_BLH_OTYPE 6
OUT_BLH_POLES 28
OUT_BLH_EXTLM 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ OUT1_MAX 2000
OUT1_TRIM 1000
OUT1_FUNCTION 36
OUT2_FUNCTION 0
OUT_BLH_MASK 3
OUT_BLH_MASK 1
OUT_BLH_OTYPE 6
OUT_BLH_POLES 28
OUT_BLH_EXTLM 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ OUT1_MAX 2000
OUT1_TRIM 1000
OUT1_FUNCTION 37
OUT2_FUNCTION 0
OUT_BLH_MASK 3
OUT_BLH_MASK 1
OUT_BLH_OTYPE 6
OUT_BLH_POLES 28
OUT_BLH_EXTLM 0
Expand Down

0 comments on commit f5a1066

Please sign in to comment.