Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option root path #2

Open
OmgImAlexis opened this issue Jan 10, 2016 · 4 comments
Open

[Feature Request] Option root path #2

OmgImAlexis opened this issue Jan 10, 2016 · 4 comments

Comments

@OmgImAlexis
Copy link

I'd be nice if there was an optional root path that would be used before the font name.
For example, this https://google-fonts.azurewebsites.net/googleFonts/openSans?family=Open+Sans&root=/fonts/ would add this.
src: local('Open Sans'), local('OpenSans'), url('/fonts/iXeptR36kaC0GEAetxlDMrAYtoOisqqMDW9M_Mqc.ttf') format('truetype');

The first slash would be optional, so adding it would make the font path absolute and not adding it would make it relative.

@supersaiyen
Copy link

While the Google Fonts Proxy could do this, its not a feature that bower supports. Bower is still going to download the font package to its bower_components folder (or other configured option). This may be better implemented as a build step in your gulp/grunt/npm scripts.

@OmgImAlexis
Copy link
Author

I'm talking about the CSS, this would allow people like myself that use Grunt and bower_concat to have the files references for instance in a vender.min.css at /fonts/ instead of the file expecting it to be in the same directory as the css file.

I don't see where bower comes into this? This would just affect the CSS file that's added with the fonts?

@ajoah
Copy link

ajoah commented Nov 21, 2016

Hi @supersaiyen :)

Any news about this issue ? For the moment we can not use your package inside a concatenated css file like said @OmgImAlexis. We have to copy the css file and change the url path :/

@supersaiyen
Copy link

I have no intentions of adding this feature, however i'd be happy to accept a pull request if you'd like to implement it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants