Update logging and error handling #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliasJRH
changed the title
linguini1
approved these changes
May 28, 2024
| @@ -8,20 +8,13 @@ | |||
| from modules.misc.converter import metres_to_feet, milli_degrees_to_celsius, pascals_to_psi | |||
|
|
|||
|
|
|||
| class BlockException(Exception): | |||
| pass | |||
| class DataBlockException(Exception): | |||
There was a problem hiding this comment.
God bless you for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some logging levels from INFO to DEBUG. This PR also adds
DataBlockExceptionwhich is raised if an error occurs while parsing a datablock and is handled by displaying the information about the block that raised the error.In the
parse_radio_blockfunction, some of the try catches were moved around to more accurately represent when errors might occur while parsing and how they should be handled.