test parse_radio_block done

[Juan-789]

^^^

[EliasJRH]

this pr should make the checking of the block contents easier once implemented. Until then can you also add some tests to ensure that we catch errors correctly?

[Juan-789]

Surely

[linguini1]

I'm not sure what this is testing that isn't covered by test_block_data and test_block_header in the tests/parsing/ directory. Was there something those test cases don't cover that you were hoping to implement? Could that test be added to one of the other test files?

[EliasJRH]

I'm not sure what this is testing that isn't covered by test_block_data and test_block_header in the tests/parsing/ directory. Was there something those test cases don't cover that you were hoping to implement? Could that test be added to one of the other test files?

I wanted to test that the parse_radio_block function works correctly when applied generally to the received information, whereas test_block_data tests for specific block types.

[linguini1]

I'm not sure what this is testing that isn't covered by test_block_data and test_block_header in the tests/parsing/ directory. Was there something those test cases don't cover that you were hoping to implement? Could that test be added to one of the other test files?

I wanted to test that the parse_radio_block function works correctly when applied generally to the received information, whereas test_block_data tests for specific block types.

Gotcha, makes sense!

[Juan-789]

Fixed the issues mentioned

[linguini1]

This PR conflicts with main so make sure you merge main and re-request a review.

[linguini1]

Please also make sure you format your code and run the workflow tests locally so they don't fail.

[Juan-789]

nvm it broke

[linguini1]

Also double check the workflows locally!